Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐋 Bump versions in Dockerfile #61

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

danstiner
Copy link
Collaborator

@danstiner danstiner commented Jan 26, 2021

Bumps default versions in docker. Local testing against #60 shows a potential reduction in grey frames.

Looked through the changelogs and found the following two changes that looked relevant:

  • janus - they disabled NACK buffer cleanup on outgoing keyframe by default [Make NACK buffer cleanup on outgoing keyframe configurable (see #2401) meetecho/janus-gateway#2402]
    • this looks related to our grey frames problem possibly, the linked discussion gets into more detail on why and has some interesting thoughts around how sending a keyframe more than once every ~five seconds can actually make the impact of packet loss worse
  • libnice - slightly more efficient from using sendmmsg if possible to send multiple packets in one call

Also includes a change to install and use g++ version 10, I noticed that was needed to get #60 to build using docker.

Tested against #60 fairly extensively.

Full changelogs:

@haydenmc haydenmc merged commit bdb2c4a into Glimesh:master Feb 8, 2021
@danstiner danstiner deleted the docker-bump-versions branch February 9, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants