Bump janus version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant change is disabling NACK buffer cleanup on outgoing keyframe by default [meetecho/janus-gateway/pull/2402], this may reduce the impact of packet loss and the frequency of grey frames.
The relevant change is they use sendmmsg if possible to send multiple packets in one call, which should be more efficient.
|
Hey! This is awesome, thank you for thinking to update |
clone1018
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting my change from Glimesh/janus-ftl-plugin#61
I've been testing with these versions locally and they work great, the improvement in grey frames from this is pretty minimal so it's not urgent to deploy these changes but I'll leave them here for your consideration.