fix: Adding credentials as parameter for Spanner (#1031)

* fix: Adding credentials as parameter for Service Account key * fix: linting fix --------- Co-authored-by: Piyush Sarraf <[email protected]>
GoogleCloudPlatform · Nov 3, 2023 · 367658e · 367658e
1 parent 8c76c1b
commit 367658e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/third_party/ibis/ibis_cloud_spanner/__init__.py b/third_party/ibis/ibis_cloud_spanner/__init__.py
@@ -38,9 +38,12 @@ def do_connect(
         instance_id: str,
         database_id: str = None,
         project_id: str = None,
+        credentials=None,
     ) -> None:
 
-        self.spanner_client = spanner.Client(project=project_id)
+        self.spanner_client = spanner.Client(
+            project=project_id, credentials=credentials
+        )
         self.instance = self.spanner_client.instance(instance_id)
         self.database_name = self.instance.database(database_id)
         (

diff --git a/third_party/ibis/ibis_cloud_spanner/api.py b/third_party/ibis/ibis_cloud_spanner/api.py
@@ -21,6 +21,7 @@ def spanner_connect(
     instance_id,
     database_id,
     project_id=None,
+    credentials=None,
 ):
     """Create a Cloud Spanner Backend for use with Ibis.
 
@@ -38,5 +39,6 @@ def spanner_connect(
         instance_id=instance_id,
         database_id=database_id,
         project_id=project_id,
+        credentials=credentials,
     )
     return backend