Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding credentials as parameter for Spanner #1031

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: Adding credentials as parameter for Spanner #1031

merged 2 commits into from
Nov 3, 2023

Conversation

piyushsarraf
Copy link
Contributor

  • This fix adds a credential parameter in connect function for spanner.
  • The credentials consist of service account key required to access the DB.

@piyushsarraf piyushsarraf requested a review from a team as a code owner November 2, 2023 06:11
@piyushsarraf
Copy link
Contributor Author

/gcbrun

@piyushsarraf piyushsarraf changed the title fix: Adding credentials as parameter for Service Account key fix: Adding credentials as parameter for Spanner Nov 2, 2023
@piyushsarraf
Copy link
Contributor Author

/gcbrun

@piyushsarraf piyushsarraf merged commit 367658e into develop Nov 3, 2023
5 checks passed
@piyushsarraf piyushsarraf deleted the spanner-error branch November 3, 2023 14:42
@release-please release-please bot mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raniksingh Raniksingh Raniksingh approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piyushsarraf @Raniksingh