fix: Issue 1127 configs dir fails with more than 40 files #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
sundar-mudupalli-work
changed the title
|
/gcbrun |
|
LGTM. I'm assuming the connections get garbage collected after the client.execute() is called in SQLAlchemy. Probably something to investigate further in the future. |
nehanene15
approved these changes
May 7, 2024
|
/gcbrun |
helensilva14
deleted the
issue-1127-configs_dir-fails-with-more-than-40-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI,
data validator built all the configurations before calling a validation. "Building" a configuration involves creating a data_client, which connects to the database. When
data-validationwas called withconfigs run -cdir <dirnname>it opens a database connection for each file in the directory before calling the first validation. This results in running out of Shared memory in the case of Oracle (limit seems to be 40 open connections)Code changed to call a validation immediately, each time after reading the yaml file from the directory. Tested this change on the same directory causing issues with the develop DVT branch. This does not run into Shared memory issues on Oracle. However, not entirely clear how this works - as data-validation does not appear to
disconnectfrom each Oracle connection.Sundar Mudupalli