Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Issue 1127 configs dir fails with more than 40 files #1130

Merged
merged 4 commits into from
May 15, 2024
Merged

fix: Issue 1127 configs dir fails with more than 40 files #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9eea92d
Updated main to run validation right after building config managers
sundar-mudupalli-work May 4, 2024
6fb270d
Updated test
sundar-mudupalli-work May 5, 2024
90bd004
Linted and black8
sundar-mudupalli-work May 5, 2024
678ae50
Merge branch 'develop' into issue-1127-configs_dir-fails-with-more-th…
helensilva14 May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions data_validation/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ def config_runner(args):
setattr(args, "config_dir", None)
setattr(args, "config_file", config_file_path)
config_managers = build_config_managers_from_yaml(args, config_file_path)
run_validations(args, config_managers)
else:
if args.kube_completions:
logging.warning(
Expand All @@ -364,16 +365,16 @@ def config_runner(args):
config_file_names = cli_tools.list_validations(config_dir=args.config_dir)
config_managers = []
for file in config_file_names:
config_managers.extend(build_config_managers_from_yaml(args, file))
config_managers = build_config_managers_from_yaml(args, file)
run_validations(args, config_managers)
else:
if args.kube_completions:
logging.warning(
"--kube-completions or -kc specified, which requires a config directory, however a specific config file is provided."
)
config_file_path = _get_arg_config_file(args)
config_managers = build_config_managers_from_yaml(args, config_file_path)

run_validations(args, config_managers)
run_validations(args, config_managers)


def build_config_managers_from_yaml(args, config_file_path):
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test__main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ def test_config_runner_2(mock_args, mock_build, mock_run, caplog):
assert caplog.messages == [
"--kube-completions or -kc specified, however not running in Kubernetes Job completion, check your command line."
]
# assert that 3 config managers are present
assert len(mock_run.call_args.args[1]) == 3
# assert that validation is called thrice, once for each file
assert mock_run.call_count == 3


@mock.patch("data_validation.__main__.run_validations")
Expand Down