fix: Hive boolean nan to None, Unsupported ibis data types in structs and arrays #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
dmedora
reviewed
Apr 13, 2022
dmedora
approved these changes
Apr 13, 2022
FX-HAO
pushed a commit
to FX-HAO/professional-services-data-validator
that referenced
this pull request
Apr 15, 2022
… and arrays (GoogleCloudPlatform#444) * fix: boolean nan issue for Hive, fixes column agg for tables with unsupported ibis data types * blacken updates after merge * add varchar and char support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #441
'{!r} cannot be parsed as a datatype'.format(value) ibis.common.exceptions.IbisTypeErrorwhen running a column aggregation on a table with struct fields (the validation itself should exclude the struct fields)