Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hive boolean nan to None, Unsupported ibis data types in structs and arrays #444

Merged
merged 4 commits into from
Apr 14, 2022
+17 −8
Merged

fix: Hive boolean nan to None, Unsupported ibis data types in structs and arrays #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
324c04f
fix: boolean nan issue for Hive, fixes column agg for tables with uns…
nehanene15 Apr 13, 2022
8a838e5
Merge remote-tracking branch 'origin/develop' into issue441-hive-boolean
nehanene15 Apr 13, 2022
4821222
blacken updates after merge
nehanene15 Apr 13, 2022
bf45f67
add varchar and char support
nehanene15 Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions data_validation/config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,13 +418,9 @@ def build_config_grouped_columns(self, grouped_columns):
for column in grouped_columns:

if column.casefold() not in casefold_source_columns:
raise ValueError(
f"GroupedColumn DNE in source: {source_table.op().name}.{column}"
)
raise ValueError(f"Grouped Column DNE in source: {column}")
if column.casefold() not in casefold_target_columns:
raise ValueError(
f"GroupedColumn DNE in target: {target_table.op().name}.{column}"
)
raise ValueError(f"Grouped Column DNE in target: {column}")
column_config = {
consts.CONFIG_SOURCE_COLUMN: casefold_source_columns[column.casefold()],
consts.CONFIG_TARGET_COLUMN: casefold_target_columns[column.casefold()],
Expand Down
17 changes: 15 additions & 2 deletions third_party/ibis/ibis_impala/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,20 @@ def parse_type(t):
else:
return ValueError(t)
elif "struct" in t or "array" in t or "map" in t:
return t.replace("int", "int32")
if "bigint" in t:
dmedora marked this conversation as resolved.
Show resolved Hide resolved
t = t.replace("bigint", "int64")
elif "tinyint" in t:
t = t.replace("tinyint", "int8")
elif "smallint" in t:
t = t.replace("smallint", "int16")
else:
t = t.replace("int", "int32")

if "varchar" in t:
t = t.replace("varchar", "string")
else:
t = t.replace("char","string")
return t
else:
raise Exception(t)

Expand Down Expand Up @@ -149,7 +162,7 @@ def fill(target, chunks, na_rep):
if have_nulls:
if numpy_type in ('bool', 'datetime64[ns]'):
target = np.empty(total_length, dtype='O')
na_rep = np.nan
na_rep = None
elif numpy_type.startswith('int'):
target = np.empty(total_length, dtype='f8')
na_rep = np.nan
Expand Down