Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Better detection of Oracle client #736

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: Better detection of Oracle client #736

merged 1 commit into from
Feb 21, 2023

Conversation

nj1973
Copy link
Contributor

@nj1973 nj1973 commented Feb 17, 2023

Better detection of OracleClient when cx-Oracle is not installed, protecting from:

TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union

@nj1973 nj1973 linked an issue Feb 17, 2023 that may be closed by this pull request
validate row: Issue with Oracle identification when no Oracle client installed #735
Closed
@nj1973
Copy link
Contributor Author

nj1973 commented Feb 17, 2023

/gcbrun

@nj1973 nj1973 mentioned this pull request Feb 21, 2023
Closed
@nj1973 nj1973 merged commit efce0b8 into develop Feb 21, 2023
@nj1973 nj1973 deleted the fix/issue-735-oracle-client-dependency branch February 21, 2023 15:56
@release-please release-please bot mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehanene15 nehanene15 nehanene15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate row: Issue with Oracle identification when no Oracle client installed
2 participants
@nj1973 @nehanene15