Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Better detection of Oracle client #736

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: Better detection of Oracle client #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion data_validation/config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,9 +715,16 @@ def build_config_calculated_fields(
def _strftime_format(
self, column_type: Union[dt.Date, dt.Timestamp], client
) -> str:
def is_oracle_client(client):
# When no Oracle client installed clients.OracleClient is not a class
try:
return isinstance(client, clients.OracleClient)
except TypeError:
return False

if isinstance(column_type, dt.Timestamp):
return "%Y-%m-%d %H:%M:%S"
if isinstance(client, clients.OracleClient):
if is_oracle_client(client):
# Oracle DATE is a DateTime
return "%Y-%m-%d %H:%M:%S"
return "%Y-%m-%d"
Expand Down