feat: added source_type in output while listing connections list #803
Conversation
|
Fixes issue: #792 data-validation connections list output is limited |
| for conn_name in connections: | ||
| logging.info(f"Connection Name: {conn_name}") | ||
| source_type = mgr.get_connection_config(conn_name).get("source_type") |
There was a problem hiding this comment.
Should we also add target_type along with source? @nehanene15 any thoughts?
There was a problem hiding this comment.
@Raniksingh
AFAIU, connection listing implies databases whose connection details is added, we can't confirm whether it is used as target when using DVT. source_type itself should suffice, it says to which source\database connection is pointing to.
There was a problem hiding this comment.
Looks good! Maybe we can update this unit test to reflect the new output - https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/tests/unit/test_cli_tools.py#L117
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
/gcbrun