Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added source_type in output while listing connections list #803

Merged
merged 7 commits into from
Apr 19, 2023
Merged

feat: added source_type in output while listing connections list #803

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
204bfdb
feat: added source_type in output while listing connections list
Apr 11, 2023
e96492c
feat: added source_type in output while listing connections list ,Uni…
Apr 18, 2023
74c64df
feat:added source_type in output while listing connections list unit …
Apr 19, 2023
4ba8941
feat:added source_type in output while listing connections list unit …
Apr 19, 2023
ec26130
feat:added source_type in output while listing connections list unit …
Apr 19, 2023
d468633
feat:added source_type in output while listing connections list-unit …
Apr 19, 2023
07ed1e1
feat:added source_type in output while listing connections list
Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data_validation/cli_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,9 +988,9 @@ def list_connections():
"""List all saved connections."""
mgr = state_manager.StateManager()
connections = mgr.list_connections()

for conn_name in connections:
logging.info(f"Connection Name: {conn_name}")
source_type = mgr.get_connection_config(conn_name).get("source_type")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add target_type along with source? @nehanene15 any thoughts?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raniksingh
AFAIU, connection listing implies databases whose connection details is added, we can't confirm whether it is used as target when using DVT. source_type itself should suffice, it says to which source\database connection is pointing to.

logging.info(f"Connection Name: {conn_name} : {source_type}")


def get_connection(connection_name):
Expand Down