Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update react-scripts to v4 #426

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Conversation

tuliomir
Copy link
Collaborator

@tuliomir tuliomir commented Oct 27, 2023

This application management is linked to the react-scripts dependency. It's necessary to update it before the others to ensure all of the latest versions of all dependencies are as inter-compatible as possible.

It was not possible to upgrade all the way to the latest version 5.0.1 because of issues described on #441 , so the upgrade finished on 4.0.3.

Acceptance Criteria

  • React Scripts should be at the latest v4 stable version: 4.0.3
  • ESLint should be also upgraded to match the internal versions from react-scripts
  • Unit tests should be adapted to changes in the updated Jest behavior

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Oct 27, 2023
@tuliomir tuliomir self-assigned this Oct 27, 2023
@tuliomir tuliomir marked this pull request as ready for review November 23, 2023 16:43
@tuliomir tuliomir requested a review from r4mmer November 29, 2023 16:12
@tuliomir tuliomir changed the title Chore: Update react-scripts Chore: Update react-scripts to v4 Nov 29, 2023
@tuliomir tuliomir merged commit 95ef19c into dev Dec 7, 2023
2 checks passed
@tuliomir tuliomir deleted the chore/update-react-scripts branch December 7, 2023 18:54
@tuliomir tuliomir mentioned this pull request Feb 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants