Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accessing colors from scss #510

Merged
merged 3 commits into from
Feb 8, 2024
Merged

fix: Accessing colors from scss #510

merged 3 commits into from
Feb 8, 2024

Conversation

tuliomir
Copy link
Collaborator

@tuliomir tuliomir commented Feb 2, 2024

After the react-scripts upgrade on #426 the colors on the loading component were incorrect. This was tracked to a known issue on CRA v4 that is currently not fixed on the stable release and probably will be available only on v5 onwards.

The chosen workaround for this bug was to rename the index.scss file to index.module.scss so that the current configurations of react-scripts can identify it and load its data correctly to the application.

To minimize future impacts related to scss interaction, this interface was also centralized and sanitized on the constants file.

Acceptance Criteria

  • Exported colors from the scss file should be retrieved from javascript context

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Feb 2, 2024
@tuliomir tuliomir requested a review from r4mmer February 2, 2024 15:18
@tuliomir tuliomir self-assigned this Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c887af) 9.20% compared to head (e276956) 9.21%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #510   +/-   ##
=====================================
  Coverage   9.20%   9.21%           
=====================================
  Files        112     112           
  Lines       5246    5253    +7     
  Branches     696     696           
=====================================
+ Hits         483     484    +1     
- Misses      4102    4108    +6     
  Partials     661     661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir linked an issue Feb 4, 2024 that may be closed by this pull request
@tuliomir tuliomir merged commit e09124a into dev Feb 8, 2024
3 checks passed
@tuliomir tuliomir deleted the fix/scss-colors branch February 8, 2024 16:17
r4mmer pushed a commit that referenced this pull request Feb 15, 2024
* fix: forceful quit (#497)
* chore: Upgrade to NodeJS 20 (#501)
* fix: Accessing colors from `scss` (#510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

colors from scss file is not working
3 participants