Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to NodeJS 20 #501

Merged
merged 2 commits into from
Feb 2, 2024
Merged

chore: Upgrade to NodeJS 20 #501

merged 2 commits into from
Feb 2, 2024

Conversation

tuliomir
Copy link
Collaborator

Acceptance Criteria

  • Should upgrade the application to use Node.js v20

Notes on SSL usage

Starting with NodeJS 17, a security fix with breaking changes was implemented and dropped support to older versions of OpenSSL ( official announcement ). So, every dependency used has to be compatible with OpenSSL 3.0 from now on.

By inserting the --openssl-legacy-provider flag on our start and build scripts we can avoid this temporarily. Adding this flag does not decrease our security, but only keeps it in the same level as it was on the last version.

A future PR will deal exclusively with upgrading this security point and removing this flag. The most relevant dependency impacting this upgrade is the react-scripts, as described on #441 .

Notes on lockfile

NodeJS 20 could handle an upgrade of the lockfile version to v3. However, this forces an update of all the patches and minor versions of all the indirect dependencies. Until the React Router is updated to v6, this approach is not feasible, as it breaks the npm install.

A dedicated PR will be opened later to upgrade the lockfile.

Notes on building

Both the development environment and the built binaries work correctly, as recorded by #493 .

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Jan 30, 2024
@tuliomir tuliomir self-assigned this Jan 30, 2024
@tuliomir tuliomir mentioned this pull request Jan 30, 2024
1 task
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9780b6a) 9.22% compared to head (a77edee) 9.22%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #501   +/-   ##
=====================================
  Coverage   9.22%   9.22%           
=====================================
  Files        112     112           
  Lines       5234    5234           
  Branches     697     697           
=====================================
  Hits         483     483           
  Misses      4089    4089           
  Partials     662     662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir merged commit 9c887af into dev Feb 2, 2024
3 checks passed
@tuliomir tuliomir deleted the chore/node20 branch February 2, 2024 10:54
r4mmer pushed a commit that referenced this pull request Feb 15, 2024
* fix: forceful quit (#497)
* chore: Upgrade to NodeJS 20 (#501)
* fix: Accessing colors from `scss` (#510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants