chore: Upgrades lockfile to version 3 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliomir
force-pushed
the
chore/update-lockfile
branch
2 times, most recently
from
e150bc0
to
491cd4d
Compare
tuliomir
force-pushed
the
chore/update-lockfile
branch
from
491cd4d
to
2f6cd30
Compare
The @testing-library/[email protected] dep had to be removed because of an incompatibility with react-scripts
tuliomir
force-pushed
the
chore/update-lockfile
branch
from
2f6cd30
to
704148f
Compare
andreabadesso
requested changes
Apr 5, 2024
pedroferreira1
approved these changes
Apr 9, 2024
andreabadesso
approved these changes
Apr 9, 2024
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the work made on #501 and upgrades the application lockfile, dealing with incompatibilities that arise from the upgrade.
Prior to this PR, the
npm installcommand could only be run on Node 14. If a developer tried to tunnpm installon Node 20 the whole lockfile would be rebuilt and compatibility errors would occur if any other dependency was changed.Steps description
We were not able to upgrade this file previous to #555 because of an incompatibility in one of the subdependencies of the React Router.
The first step was to only upgrade the lockfile version without changing any of its dependencies, which was done using
npm install --lockfile-version 3command. ( e603860 )The next step was to actually run
npm installon Node 20, which prompted many changes to the lockfile to respect the new environment. This command was previously run only on Node 14. ( 813bf7f ).As a consequence, the
pottranslation files failed and had to be updated usingmake update_pot( 5e362c4 )Lastly,
react-scriptsbegan to fail all jest tests, because react-scriptsv4requires Jestv26and our React18tests require Jestv29. We tried using theSKIP_PREFLIGHT_CHECK=trueflag to allow the version mismatch not to break the CI, but it utimately broke the test run itself. Another approach would be to rewrite the tests using an older version of the react testing library.Since the tests were still on a stub implementation that do not improve our quality control, they were disabled until we can upgrade
react-scripts, as described on #441. ( 704148f )Acceptance Criteria
package-lock.jsonshould be upgraded to v3npm installon a development environment should not change the contents ofpackage-lock.jsonSecurity Checklist