-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to the main branch #715
Conversation
* Update model version constant to 3.1.0 * Return gmst instead of tas; update model version (#705) * Add video and tutorial links * Update to reflect BBL's PR feedback. --------- Co-authored-by: Robert Gieseke <[email protected]>
Expand the fetchvars documentation.
fix : convert trailing comments to single sline comments
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.0.0 (9aebf67). |
Codecov Report
@@ Coverage Diff @@
## dev #715 +/- ##
======================================
Coverage ? 79.72%
======================================
Files ? 61
Lines ? 5978
Branches ? 0
======================================
Hits ? 4766
Misses ? 1212
Partials ? 0 |
@bpbond and @crvernon this should address the code changes fro #697 , I think. I think the outstanding TODOs would be to change the default branch on github and then the default branch on code cov. Do we do that now? Or wait until this is merged into master and then update? Does it need a new release associated with that change? What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine; thanks @kdorheim
@@ -3,7 +3,7 @@ name: R-CMD-check | |||
on: | |||
push: | |||
branches: | |||
- master | |||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or do we want to just add - main
for now, do the branch switch, ensure everything working, and then finally delete the - main
line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point idk, I guess it depends on what the order of merging is and such.
@kdorheim I'm not sure of the best sequence here, but I guess I would merge this into master and then update the branch name. Don't see the need for a new release since there's no code change. |
Yea I am also at a loss here 🤷♀️ |
This is to address #697 to change from the default branch from being master to main. To do this will need to update the github action files and documentation.