Ignore static-static collisions in broad phase #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
bugfix
A-Collision
|
|
|
Ah this should check the |
|
Should be fixed by #285, thanks for reporting the issue. A dumb oversight on my part :P |
Jondolf
added a commit
that referenced
this pull request
Dec 28, 2023
# Objective #283 had an oversight where it required colliders to have a `RigidBody` for AABBs to be updated. It also didn't handle child colliders. ## Solution Use the `ColliderParent` to get the (optional) `RigidBody` of the entity the collider is attached to.
Jondolf
added
C-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently, the broad phase determines whether a body is inactive just by checking if the position or rotation has changed. If a static body is moved, it will unnecessarily check collisions against other static bodies. This can cause performance issues with e.g. floating point worlds where all entities are frequently moved.
Solution
Also check whether the body is static in the
update_aabb_intervalssystem.