Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static body handling in update_aabb_intervals #285

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Fix static body handling in update_aabb_intervals #285

merged 1 commit into from
Dec 28, 2023

Conversation

Jondolf
Copy link
Owner

@Jondolf Jondolf commented Dec 28, 2023

Objective

#283 had an oversight where it required colliders to have a RigidBody for AABBs to be updated. It also didn't handle child colliders.

Solution

Use the ColliderParent to get the (optional) RigidBody of the entity the collider is attached to.

@Jondolf Jondolf added bugfix A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality labels Dec 28, 2023
@Jondolf Jondolf mentioned this pull request Dec 28, 2023
Merged
@Jondolf Jondolf merged commit 2f0309d into main Dec 28, 2023
4 checks passed
@Jondolf Jondolf deleted the fix-static-body-aabb-intervals branch December 28, 2023 13:00
@Jondolf Jondolf added C-Bug Something isn't working and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality C-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jondolf