Android: migrate away from JCenter (#1728)

* Replace expo-image-picker by react-native-image-picker to avoid a build issue on Android side

* changeset

* Replace jcenter by maven

* Patch usages of JCenter in react-native-os, react-native-tcp, rn-fetch-blob

* fix react-native-tcp patch

.changeset/afraid-spiders-rule.md

@@ -0,0 +1,5 @@
+---
+"live-mobile": patch
+---
+
+Migrate from expo-image-picker to react-native-image-picker to kill a JCenter dependency

apps/ledger-live-mobile/android/build.gradle

@@ -37,6 +37,19 @@ buildscript {
 
 allprojects {
     repositories {
+        def REPOSITORY_URL = 'https://repo1.maven.org/maven2'
+        all { ArtifactRepository repo ->
+            if(repo instanceof MavenArtifactRepository){
+                def url = repo.url.toString()
+                if (url.startsWith('https://jcenter.bintray.com/')) {
+                    project.logger.lifecycle "Repository ${repo.url} replaced by $REPOSITORY_URL."
+                    remove repo
+                }
+            }
+        }
+        maven {
+            url REPOSITORY_URL
+        }
         mavenLocal()
         maven {
             // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
@@ -57,11 +70,6 @@ allprojects {
         maven {
             url "$rootDir/../node_modules/expo-camera/android/maven"
         }
-        jcenter() {
-            content {
-                includeModule("com.theartofdev.edmodo", "android-image-cropper") // for expo-image-picker
-            }
-        }
     }
     configurations.all {
         resolutionStrategy {

apps/ledger-live-mobile/ios/Podfile.lock

@@ -21,8 +21,6 @@ PODS:
   - EXImageManipulator (10.2.1):
     - EXImageLoader
     - ExpoModulesCore
-  - EXImagePicker (12.0.2):
-    - ExpoModulesCore
   - Expo (43.0.5):
     - ExpoModulesCore
   - ExpoModulesCore (0.6.5):
@@ -427,6 +425,8 @@ PODS:
   - react-native-image-crop-tools (1.6.2):
     - React
     - TOCropViewController (= 2.5.3)
+  - react-native-image-picker (4.8.5):
+    - React-Core
   - react-native-netinfo (6.2.1):
     - React-Core
   - react-native-performance (3.1.2):
@@ -631,7 +631,6 @@ DEPENDENCIES:
   - "EXFileSystem (from `../../../node_modules/.pnpm/[email protected][email protected]/node_modules/expo-file-system/ios`)"
   - "EXImageLoader (from `../../../node_modules/.pnpm/[email protected][email protected]/node_modules/expo-image-loader/ios`)"
   - "EXImageManipulator (from `../../../node_modules/.pnpm/[email protected][email protected]/node_modules/expo-image-manipulator/ios`)"
-  - "EXImagePicker (from `../../../node_modules/.pnpm/[email protected][email protected]/node_modules/expo-image-picker/ios`)"
   - "Expo (from `../../../node_modules/.pnpm/[email protected]_@[email protected]/node_modules/expo/ios`)"
   - "ExpoModulesCore (from `../../../node_modules/.pnpm/[email protected]/node_modules/expo-modules-core/ios`)"
   - "FBLazyVector (from `../../../node_modules/.pnpm/[email protected]_qiqqwmyv63yhnuboofexv3s7x4/node_modules/react-native/Libraries/FBLazyVector`)"
@@ -687,6 +686,7 @@ DEPENDENCIES:
   - "react-native-fast-crypto (from `../../../node_modules/.pnpm/[email protected][email protected]/node_modules/react-native-fast-crypto`)"
   - "react-native-flipper (from `../../../node_modules/.pnpm/[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-flipper`)"
   - "react-native-image-crop-tools (from `../../../node_modules/.pnpm/[email protected]_ykxjy5s7xujdxmsgrwxo5mh3y4_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-image-crop-tools`)"
+  - "react-native-image-picker (from `../../../node_modules/.pnpm/[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-image-picker`)"
   - "react-native-netinfo (from `../../../node_modules/.pnpm/@[email protected][email protected]/node_modules/@react-native-community/netinfo`)"
   - "react-native-performance (from `../../../node_modules/.pnpm/[email protected][email protected]/node_modules/react-native-performance`)"
   - "react-native-randombytes (from `../../../node_modules/.pnpm/[email protected]/node_modules/react-native-randombytes`)"
@@ -710,7 +710,7 @@ DEPENDENCIES:
   - "React-RCTVibration (from `../../../node_modules/.pnpm/[email protected]_qiqqwmyv63yhnuboofexv3s7x4/node_modules/react-native/Libraries/Vibration`)"
   - "React-runtimeexecutor (from `../../../node_modules/.pnpm/[email protected]_qiqqwmyv63yhnuboofexv3s7x4/node_modules/react-native/ReactCommon/runtimeexecutor`)"
   - "ReactCommon/turbomodule/core (from `../../../node_modules/.pnpm/[email protected]_qiqqwmyv63yhnuboofexv3s7x4/node_modules/react-native/ReactCommon`)"
-  - "rn-fetch-blob (from `../../../node_modules/.pnpm/[email protected].0/node_modules/rn-fetch-blob`)"
+  - "rn-fetch-blob (from `../../../node_modules/.pnpm/[email protected].0_n5yzdsrxz654upecs5xliebtmm/node_modules/rn-fetch-blob`)"
   - "RNAnalytics (from `../../../node_modules/.pnpm/@[email protected]/node_modules/@segment/analytics-react-native`)"
   - "RNCAsyncStorage (from `../../../node_modules/.pnpm/@[email protected][email protected]/node_modules/@react-native-async-storage/async-storage`)"
   - "RNCClipboard (from `../../../node_modules/.pnpm/@[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/@react-native-community/clipboard`)"
@@ -722,7 +722,7 @@ DEPENDENCIES:
   - "RNGestureHandler (from `../../../node_modules/.pnpm/[email protected]_mk7ksnag22facomrynqrp7v6gy/node_modules/react-native-gesture-handler`)"
   - "RNKeychain (from `../../../node_modules/.pnpm/[email protected]/node_modules/react-native-keychain`)"
   - "RNLocalize (from `../../../node_modules/.pnpm/[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-localize`)"
-  - "RNOS (from `../../../node_modules/.pnpm/[email protected].6/node_modules/react-native-os`)"
+  - "RNOS (from `../../../node_modules/.pnpm/[email protected].6_2e25ffb547hjiczrnsjhxl6geu/node_modules/react-native-os`)"
   - "RNReanimated (from `../../../node_modules/.pnpm/[email protected]_q4bsppkovizpw5uw6ytm5z2tba/node_modules/react-native-reanimated`)"
   - "RNScreens (from `../../../node_modules/.pnpm/[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-screens`)"
   - "RNSentry (from `../../../node_modules/.pnpm/@[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/@sentry/react-native`)"
@@ -789,8 +789,6 @@ EXTERNAL SOURCES:
     :path: "../../../node_modules/.pnpm/[email protected][email protected]/node_modules/expo-image-loader/ios"
   EXImageManipulator:
     :path: "../../../node_modules/.pnpm/[email protected][email protected]/node_modules/expo-image-manipulator/ios"
-  EXImagePicker:
-    :path: "../../../node_modules/.pnpm/[email protected][email protected]/node_modules/expo-image-picker/ios"
   Expo:
     :path: "../../../node_modules/.pnpm/[email protected]_@[email protected]/node_modules/expo/ios"
   ExpoModulesCore:
@@ -849,6 +847,8 @@ EXTERNAL SOURCES:
     :path: "../../../node_modules/.pnpm/[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-flipper"
   react-native-image-crop-tools:
     :path: "../../../node_modules/.pnpm/[email protected]_ykxjy5s7xujdxmsgrwxo5mh3y4_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-image-crop-tools"
+  react-native-image-picker:
+    :path: "../../../node_modules/.pnpm/[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-image-picker"
   react-native-netinfo:
     :path: "../../../node_modules/.pnpm/@[email protected][email protected]/node_modules/@react-native-community/netinfo"
   react-native-performance:
@@ -896,7 +896,7 @@ EXTERNAL SOURCES:
   ReactCommon:
     :path: "../../../node_modules/.pnpm/[email protected]_qiqqwmyv63yhnuboofexv3s7x4/node_modules/react-native/ReactCommon"
   rn-fetch-blob:
-    :path: "../../../node_modules/.pnpm/[email protected].0/node_modules/rn-fetch-blob"
+    :path: "../../../node_modules/.pnpm/[email protected].0_n5yzdsrxz654upecs5xliebtmm/node_modules/rn-fetch-blob"
   RNAnalytics:
     :path: "../../../node_modules/.pnpm/@[email protected]/node_modules/@segment/analytics-react-native"
   RNCAsyncStorage:
@@ -920,7 +920,7 @@ EXTERNAL SOURCES:
   RNLocalize:
     :path: "../../../node_modules/.pnpm/[email protected]_zqxy7fpkavjkgz5xll7ed4r6rq/node_modules/react-native-localize"
   RNOS:
-    :path: "../../../node_modules/.pnpm/[email protected].6/node_modules/react-native-os"
+    :path: "../../../node_modules/.pnpm/[email protected].6_2e25ffb547hjiczrnsjhxl6geu/node_modules/react-native-os"
   RNReanimated:
     :path: "../../../node_modules/.pnpm/[email protected]_q4bsppkovizpw5uw6ytm5z2tba/node_modules/react-native-reanimated"
   RNScreens:
@@ -951,7 +951,6 @@ SPEC CHECKSUMS:
   EXFileSystem: 08a3033ac372b6346becf07839e1ccef26fb1058
   EXImageLoader: 347b72c2ec2df65120ccec40ea65a4c4f24317ff
   EXImageManipulator: 60d1bf3f1d7709453b1feb38adf8594b7f58710f
-  EXImagePicker: bf4d62532cc2bf217edbe4abbb0014e73e079eac
   Expo: d9588796cd19999da4d440d87bf7eb7ae4dbd608
   ExpoModulesCore: 32c0ccb47f477d330ee93db72505380adf0de09a
   FBLazyVector: a7a655862f6b09625d11c772296b01cd5164b648
@@ -1008,6 +1007,7 @@ SPEC CHECKSUMS:
   react-native-fast-crypto: 5943c42466b86ad70be60d3a5f64bd22251e5d9e
   react-native-flipper: 7eeb9b59b667dd0619372c7349cf7c78032d1de2
   react-native-image-crop-tools: 06b171ac13f1cd520e633a0d190c00f664b4cb79
+  react-native-image-picker: cd420f97f6ed6ff74fc4686d27dbcfdbd051db91
   react-native-netinfo: 3d3769f0d65de15c83a9bf1346f8be71de5a24bf
   react-native-performance: e66c3730f9e463b959dc21ff38fd2c8b8e53ea79
   react-native-randombytes: 421f1c7d48c0af8dbcd471b0324393ebf8fe7846

apps/ledger-live-mobile/package.json

@@ -116,7 +116,6 @@
     "expo-file-system": "~13.1.3",
     "expo-image-loader": "~3.1.1",
     "expo-image-manipulator": "~10.2.1",
-    "expo-image-picker": "12.0.2",
     "expo-modules-autolinking": "^0.5.5",
     "expo-modules-core": "^0.6.5",
     "fuse.js": "^6.4.6",
@@ -150,6 +149,7 @@
     "react-native-fast-image": "^8.5.11",
     "react-native-gesture-handler": "^2.5.0",
     "react-native-image-crop-tools": "^1.6.2",
+    "react-native-image-picker": "4.8.5",
     "react-native-keyboard-aware-scroll-view": "^0.9.5",
     "react-native-keychain": "^7.0.0",
     "react-native-level-fs": "^3.0.0",

apps/ledger-live-mobile/src/components/CustomImage/imageUtils.ts

@@ -1,6 +1,6 @@
 import { Image, NativeModules, Platform } from "react-native";
 import RNFetchBlob from "rn-fetch-blob";
-import * as ImagePicker from "expo-image-picker";
+import * as ImagePicker from "react-native-image-picker";
 import {
   ImageDownloadError,
   ImageLoadFromGalleryError,
@@ -26,11 +26,21 @@ export async function importImageFromPhoneGallery(): Promise<ImageFileUri | null
     const pickImagePromise =
       Platform.OS === "android"
         ? NativeModules.ImagePickerModule.pickImage()
-        : ImagePicker.launchImageLibraryAsync({
-            mediaTypes: ImagePicker.MediaTypeOptions.Images,
-            allowsEditing: false,
+        : ImagePicker.launchImageLibrary({
+            mediaType: "photo",
             quality: 1,
-            base64: false,
+            includeBase64: false,
+          }).then(res => {
+            if (res.errorCode)
+              throw new Error(
+                `ImagePicker.launchImageLibrary Error (error code: ${res.errorCode}): ${res.errorMessage}`,
+              );
+            const assets = res?.assets || [];
+            if (assets.length === 0) throw new Error("Assets length is 0");
+            return {
+              cancelled: res.didCancel,
+              uri: assets[0]?.uri,
+            };
           });
     const { uri, cancelled } = await pickImagePromise;
     if (cancelled) return null;

package.json

@@ -119,7 +119,10 @@
     "patchedDependencies": {
       "[email protected]": "patches/[email protected]",
       "[email protected]": "patches/[email protected]",
-      "[email protected]": "patches/[email protected]"
+      "[email protected]": "patches/[email protected]",
+      "[email protected]": "patches/[email protected]",
+      "[email protected]": "patches/[email protected]",
+      "[email protected]": "patches/[email protected]"
     }
   }
 }

patches/react-native-os@1.2.6.patch

@@ -0,0 +1,13 @@
+diff --git a/android/build.gradle b/android/build.gradle
+index 7055b60151a2cbbf7aa1727dcb9515b641f74038..3e9eedea016598daebd354966788540cf4224561 100644
+--- a/android/build.gradle
++++ b/android/build.gradle
+@@ -4,7 +4,7 @@ def safeExtGet(prop, fallback) {
+
+ buildscript {
+     repositories {
+-        jcenter()
++        mavenCentral()
+     }
+
+     dependencies {

patches/react-native-tcp@4.0.0.patch

@@ -0,0 +1,13 @@
+diff --git a/android/build.gradle b/android/build.gradle
+index c582eb746ea7ffdbdf49290484fa58ea10ff7957..e4cf5a39d1adc24225ec85068f8ac34c731e6e2b 100644
+--- a/android/build.gradle
++++ b/android/build.gradle
+@@ -4,7 +4,7 @@ def safeExtGet(prop, fallback) {
+
+ buildscript {
+     repositories {
+-        jcenter()
++        mavenCentral()
+     }
+
+     dependencies {

patches/rn-fetch-blob@0.12.0.patch

@@ -0,0 +1,13 @@
+diff --git a/android/build.gradle b/android/build.gradle
+index a4ca7a421bff66bcc378c1092474bac6b7a82738..c87a49033ffa36b10017b6626c90b39570680edc 100644
+--- a/android/build.gradle
++++ b/android/build.gradle
+@@ -12,7 +12,7 @@ repositories {
+
+ buildscript {
+     repositories {
+-        jcenter()
++        mavenCentral()
+         google()
+     }
+     dependencies {