-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: migrate away from JCenter #1728
Conversation
…ld issue on Android side
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 73baac4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 47.94% // Head: 47.94% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1728 +/- ##
==========================================
Coverage 47.94% 47.94%
==========================================
Files 691 691
Lines 30445 30445
Branches 7977 7954 -23
==========================================
Hits 14598 14598
- Misses 14635 15783 +1148
+ Partials 1212 64 -1148
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd that we are doing this again, the top level image cropper from jcenter shouldn't have passed dev review in the first place 🤔 but this looks good to me.
Rerunning the failed job, if it fails we'll have to run it all again, I don't see why it would fail on the ubuntu machine only. |
📝 Description
JCenter is currently down (forever?) and has been officially deprecated for a while. IMO we should ensure that we don't use any lib that uses it as whenever it is down our CI won't be able to build for Android.
Fixes include:
expo-image-picker
toreact-native-image-picker
. We could bumpexpo-image-picker
instead but actually can't because of a tech debt we have related to AndroidtargetSdkVersion
/compileSdkVersion
. To figure out in a separate PR maybe?jcenter()
in theirbuild.gradle
, replace it bymavenCentral()
❓ Context
ledger-live-mobile
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.