Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: migrate away from JCenter #1728

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Oct 31, 2022

📝 Description

JCenter is currently down (forever?) and has been officially deprecated for a while. IMO we should ensure that we don't use any lib that uses it as whenever it is down our CI won't be able to build for Android.

Fixes include:

  • Migrate expo-image-picker to react-native-image-picker. We could bump expo-image-picker instead but actually can't because of a tech debt we have related to Android targetSdkVersion/compileSdkVersion. To figure out in a separate PR maybe?
  • Patch third party libs that were using jcenter() in their build.gradle, replace it by mavenCentral()
  • ... TBD, if someone manages to get a list of the dependencies that depend on JCenter that would be great

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): FAT-598

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 4:09PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 31, 2022 at 4:09PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 31, 2022 at 4:09PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 31, 2022 at 4:09PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022

🦋 Changeset detected

Latest commit: 73baac4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 47.94% // Head: 47.94% // No change to project coverage 👍

Coverage data is based on head (73baac4) compared to base (e1cb3aa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1728     +/-   ##
==========================================
  Coverage    47.94%   47.94%             
==========================================
  Files          691      691             
  Lines        30445    30445             
  Branches      7977     7954     -23     
==========================================
  Hits         14598    14598             
- Misses       14635    15783   +1148     
+ Partials      1212       64   -1148     
Flag Coverage Δ
test 47.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/env.ts 74.50% <0.00%> (ø)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ø)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ø)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ø)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ø)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ø)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ø)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ø)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ø)
libs/ledger-live-common/src/apps/logic.ts 89.71% <0.00%> (ø)
... and 258 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 31, 2022

@ofreyssinet-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Copy link
Contributor

@juan-cortes juan-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd that we are doing this again, the top level image cropper from jcenter shouldn't have passed dev review in the first place 🤔 but this looks good to me.

@juan-cortes
Copy link
Contributor

Rerunning the failed job, if it fails we'll have to run it all again, I don't see why it would fail on the ubuntu machine only.

@ofreyssinet-ledger ofreyssinet-ledger merged commit 135838d into develop Nov 2, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/android-build-issues branch November 2, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants