fix post onboarding redirection (#1731)

.changeset/new-toys-crash.md

@@ -0,0 +1,5 @@
+---
+"live-mobile": patch
+---
+
+Fix the post onboarding redirection if there is no action

.changeset/quick-cups-lie.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/live-common": patch
+---
+
+Filter the post onboarding actions using Feature Flags

apps/ledger-live-mobile/src/screens/Onboarding/steps/pairNew.tsx

@@ -114,16 +114,20 @@ function OnboardingStepPairNew() {
       screen: NavigatorName.Main,
     });
 
-    startPostOnboarding(deviceModelId as DeviceModelId);
+    startPostOnboarding(deviceModelId as DeviceModelId, false, () =>
+      navigation.navigate(NavigatorName.Base, {
+        screen: NavigatorName.Main,
+      }),
+    );
 
     triggerJustFinishedOnboardingNewDevicePushNotificationModal();
   }, [
     dispatch,
-    navigation,
     resetCurrentStep,
-    triggerJustFinishedOnboardingNewDevicePushNotificationModal,
+    navigation,
     startPostOnboarding,
     deviceModelId,
+    triggerJustFinishedOnboardingNewDevicePushNotificationModal,
   ]);
 
   const nextPage = useCallback(() => {

apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingDebugScreen.tsx

@@ -1,43 +1,44 @@
 import { DeviceModelId } from "@ledgerhq/devices/index";
 import { Flex } from "@ledgerhq/native-ui";
 import React, { useCallback } from "react";
+import { useNavigation } from "@react-navigation/native";
 import { useStartPostOnboardingCallback } from "@ledgerhq/live-common/postOnboarding/hooks/index";
 import PostOnboardingEntryPointCard from "../../components/PostOnboarding/PostOnboardingEntryPointCard";
 import SettingsRow from "../../components/SettingsRow";
 import { useNavigateToPostOnboardingHubCallback } from "../../logic/postOnboarding/useNavigateToPostOnboardingHubCallback";
+import { NavigatorName } from "../../const";
 
 export default () => {
+  const navigation = useNavigation();
   const startPostOnboarding = useStartPostOnboardingCallback();
 
-  const handleInitFTSMock = useCallback(
-    () => startPostOnboarding(DeviceModelId.nanoFTS, true),
-    [startPostOnboarding],
-  );
-  const handleInitFTS = useCallback(
-    () => startPostOnboarding(DeviceModelId.nanoFTS),
-    [startPostOnboarding],
-  );
-  const handleInitNanoXMock = useCallback(
-    () => startPostOnboarding(DeviceModelId.nanoX, true),
-    [startPostOnboarding],
+  const handleInitPostOnboardingHub = useCallback(
+    (deviceId: DeviceModelId, mock: boolean) =>
+      startPostOnboarding(deviceId, mock, () =>
+        navigation.navigate(NavigatorName.Main),
+      ),
+    [navigation, startPostOnboarding],
   );
+
   const navigateToPostOnboardingHub = useNavigateToPostOnboardingHubCallback();
   return (
     <Flex>
       <SettingsRow
         title="Start (mock) post onboarding for nanoFTS"
         desc="Pressing this should trigger navigation to the post onboarding hub populated with a list of actions."
-        onPress={handleInitFTSMock}
+        onPress={() => handleInitPostOnboardingHub(DeviceModelId.nanoFTS, true)}
       />
       <SettingsRow
         title="Start post onboarding for nanoFTS"
         desc="Pressing this should trigger navigation to the post onboarding hub populated with a list of actions."
-        onPress={handleInitFTS}
+        onPress={() =>
+          handleInitPostOnboardingHub(DeviceModelId.nanoFTS, false)
+        }
       />
       <SettingsRow
         title="Start (mock) post onboarding for nanoX"
         desc="Pressing this should not do anything. (no actions configured for this device)."
-        onPress={handleInitNanoXMock}
+        onPress={() => handleInitPostOnboardingHub(DeviceModelId.nanoX, true)}
       />
       <SettingsRow
         title="Open post onboarding hub"

apps/ledger-live-mobile/src/screens/SyncOnboarding/CompletionScreen.tsx

@@ -47,7 +47,11 @@ const CompletionScreen = ({ navigation, route }: Props) => {
         },
       ],
     });
-    startPostOnboarding(device.modelId);
+    startPostOnboarding(device.modelId, false, () =>
+      navigation.navigate(NavigatorName.Base, {
+        screen: NavigatorName.Main,
+      }),
+    );
   }, [device.modelId, navigation, startPostOnboarding]);
 
   const skipDelay = useCallback(() => {

libs/ledger-live-common/src/postOnboarding/hooks/useStartPostOnboardingCallback.ts

@@ -2,6 +2,7 @@ import { useDispatch } from "react-redux";
 import { DeviceModelId } from "@ledgerhq/types-devices";
 import { usePostOnboardingContext } from "./usePostOnboardingContext";
 import { useCallback } from "react";
+import { useFeatureFlags } from "../../featureFlags";
 import { initPostOnboarding } from "../actions";
 
 /**
@@ -20,6 +21,7 @@ export function useStartPostOnboardingCallback(): (
   fallbackIfNoAction?: () => void
 ) => void {
   const dispatch = useDispatch();
+  const { getFeature } = useFeatureFlags();
   const { getPostOnboardingActionsForDevice, navigateToPostOnboardingHub } =
     usePostOnboardingContext();
 
@@ -29,7 +31,14 @@ export function useStartPostOnboardingCallback(): (
       mock = false,
       fallbackIfNoAction?: () => void
     ) => {
-      const actions = getPostOnboardingActionsForDevice(deviceModelId, mock);
+      const actions = getPostOnboardingActionsForDevice(
+        deviceModelId,
+        mock
+      ).filter(
+        (actionWithState) =>
+          !actionWithState.featureFlagId ||
+          getFeature(actionWithState.featureFlagId)?.enabled
+      );
       dispatch(
         initPostOnboarding({
           deviceModelId,
@@ -45,6 +54,11 @@ export function useStartPostOnboardingCallback(): (
       }
       navigateToPostOnboardingHub();
     },
-    [dispatch, getPostOnboardingActionsForDevice, navigateToPostOnboardingHub]
+    [
+      dispatch,
+      getFeature,
+      getPostOnboardingActionsForDevice,
+      navigateToPostOnboardingHub,
+    ]
   );
 }