-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix post onboarding redirection #1731
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: b118251 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingDebugScreen.tsx
Outdated
Show resolved
Hide resolved
(actionWithState) => | ||
!actionWithState.featureFlagId || | ||
getFeature(actionWithState.featureFlagId)?.enabled | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π noice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix :)
Codecov ReportBase: 47.94% // Head: 47.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1731 +/- ##
===========================================
- Coverage 47.94% 47.34% -0.61%
===========================================
Files 691 666 -25
Lines 30458 29403 -1055
Branches 7990 7829 -161
===========================================
- Hits 14604 13920 -684
+ Misses 14657 14355 -302
+ Partials 1197 1128 -69
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
5735afe
to
af4c62c
Compare
π Description
This PR fix the post onboarding hub redirection if there is no action for the user
β Context
ledger-live-mobile
ledger-live-common
β Checklist
πΈ Demo
DM me on Slack to have a video demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.