Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix post onboarding redirection #1731

Merged
merged 5 commits into from
Nov 3, 2022

Conversation

pierrelouis-c
Copy link
Contributor

@pierrelouis-c pierrelouis-c commented Oct 31, 2022

πŸ“ Description

This PR fix the post onboarding hub redirection if there is no action for the user

❓ Context

  • Impacted projects: ledger-live-mobile ledger-live-common
  • Linked resource(s): FAT-560

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

DM me on Slack to have a video demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 3, 2022 at 10:44AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 3, 2022 at 10:44AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 3, 2022 at 10:44AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 3, 2022 at 10:44AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022

πŸ¦‹ Changeset detected

Latest commit: b118251

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
live-mobile Patch
@ledgerhq/live-common Patch
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

(actionWithState) =>
!actionWithState.featureFlagId ||
getFeature(actionWithState.featureFlagId)?.enabled
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘Œ noice

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix :)

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 47.94% // Head: 47.34% // Decreases project coverage by -0.60% ⚠️

Coverage data is based on head (af4c62c) compared to base (e890442).
Patch has no changes to coverable lines.

❗ Current head af4c62c differs from pull request most recent head b118251. Consider uploading reports for the commit b118251 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1731      +/-   ##
===========================================
- Coverage    47.94%   47.34%   -0.61%     
===========================================
  Files          691      666      -25     
  Lines        30458    29403    -1055     
  Branches      7990     7829     -161     
===========================================
- Hits         14604    13920     -684     
+ Misses       14657    14355     -302     
+ Partials      1197     1128      -69     
Flag Coverage Ξ”
test 47.34% <ΓΈ> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-btc/src/BtcNew.ts 92.25% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-btc/src/varint.ts 30.76% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-tezos/src/Tezos.ts 11.34% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-helium/src/Helium.ts 89.28% <0.00%> (ΓΈ)
.../ledgerjs/packages/hw-app-btc/src/newops/psbtv2.ts 67.51% <0.00%> (ΓΈ)
.../ledgerjs/packages/hw-app-polkadot/src/Polkadot.ts 20.77% <0.00%> (ΓΈ)
...dgerjs/packages/hw-app-btc/src/newops/appClient.ts 23.07% <0.00%> (ΓΈ)
...dgerjs/packages/hw-app-btc/src/newops/merkleMap.ts 20.00% <0.00%> (ΓΈ)
...dgerjs/packages/hw-app-btc/src/splitTransaction.ts 73.07% <0.00%> (ΓΈ)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 31, 2022

@pierrelouis-c

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants