Support: FAT-462 LLM handle 0x5515 response for basic device actions (#…

…1685)

* fix: remove deprecated Observable.create

* support: handle 5515 locked device in connect-manager action

* support: handle isLocked 5515 in LLM device action

* support handle 5515 locked device in connect-app device actions

* chore: changeset

* chore: some cleaning on StatusCodes

* fix: isLocked nullable type

* fix: USBEmpty files names

.changeset/tidy-bats-smash.md

@@ -0,0 +1,6 @@
+---
+"live-mobile": patch
+"@ledgerhq/live-common": patch
+---
+
+Handle 0x5515 response for allow manager and connect app device actions on LLM

apps/ledger-live-mobile/src/components/DeviceAction/index.tsx

@@ -67,6 +67,7 @@ type Status = PartialNullable<{
   appAndVersion: AppAndVersion;
   device: Device;
   unresponsive: boolean;
+  isLocked: boolean;
   error: LedgerError & {
     name?: string;
     managerAppName?: string;
@@ -174,6 +175,7 @@ export function DeviceActionDefaultRendering<R, H extends Status, P>({
     appAndVersion,
     device,
     unresponsive,
+    isLocked,
     error,
     isLoading,
     allowManagerRequestedWording,
@@ -447,11 +449,12 @@ export function DeviceActionDefaultRendering<R, H extends Status, P>({
     });
   }
 
-  if ((!isLoading && !device) || unresponsive) {
+  if ((!isLoading && !device) || unresponsive || isLocked) {
     return renderConnectYourDevice({
       t,
       device: selectedDevice,
       unresponsive,
+      isLocked: isLocked === null ? undefined : isLocked,
       colors,
       theme,
       onSelectDeviceLink,

apps/ledger-live-mobile/src/components/DeviceAction/rendering.tsx

@@ -749,11 +749,13 @@ export function renderDeviceNotOnboarded({
 export function renderConnectYourDevice({
   t,
   unresponsive,
+  isLocked = false,
   device,
   theme,
   onSelectDeviceLink,
 }: RawProps & {
   unresponsive?: boolean | null;
+  isLocked?: boolean;
   device: Device;
   onSelectDeviceLink?: () => void;
 }) {
@@ -767,7 +769,7 @@ export function renderConnectYourDevice({
         <Animation
           source={getDeviceAnimation({
             device,
-            key: unresponsive ? "enterPinCode" : "plugAndPinCode",
+            key: isLocked || unresponsive ? "enterPinCode" : "plugAndPinCode",
             theme,
           })}
         />
@@ -777,7 +779,7 @@ export function renderConnectYourDevice({
       )}
       <TitleText>
         {t(
-          unresponsive
+          isLocked || unresponsive
             ? "DeviceAction.unlockDevice"
             : device.wired
             ? "DeviceAction.connectAndUnlockDevice"

libs/ledger-live-common/src/hw/actions/app.ts

@@ -87,6 +87,7 @@ export type State = {
   installQueue?: string[];
   currentAppOp?: AppOp;
   itemProgress?: number;
+  isLocked: boolean;
 };
 
 export type AppState = State & {
@@ -161,6 +162,7 @@ const getInitialState = (
   requestQuitApp: false,
   requestOpenApp: null,
   unresponsive: false,
+  isLocked: false,
   requiresAppInstallation: null,
   allowOpeningRequestedWording: null,
   allowOpeningGranted: false,
@@ -188,6 +190,11 @@ const reducer = (state: State, e: Event): State => {
     case "unresponsiveDevice":
       return { ...state, unresponsive: true };
 
+    case "lockedDevice":
+      return { ...state, isLocked: true };
+
+    // This event does not set isLocked and unresponsive properties, as
+    // by itself it does not request anything from the device
     case "device-update-last-seen":
       return {
         ...state,
@@ -220,6 +227,7 @@ const reducer = (state: State, e: Event): State => {
         derivation: null,
         displayUpgradeWarning: false,
         unresponsive: false,
+        isLocked: false,
         installingApp: true,
         progress: e.progress || 0,
         requestOpenApp: null,
@@ -232,7 +240,12 @@ const reducer = (state: State, e: Event): State => {
       };
 
     case "listing-apps":
-      return { ...state, listingApps: true };
+      return {
+        ...state,
+        listingApps: true,
+        unresponsive: false,
+        isLocked: false,
+      };
 
     case "error":
       return {
@@ -260,6 +273,7 @@ const reducer = (state: State, e: Event): State => {
         derivation: null,
         displayUpgradeWarning: false,
         unresponsive: false,
+        isLocked: false,
         requestOpenApp: e.appName,
         request: state.request,
       };
@@ -280,6 +294,7 @@ const reducer = (state: State, e: Event): State => {
         derivation: null,
         displayUpgradeWarning: false,
         unresponsive: false,
+        isLocked: false,
         requestQuitApp: true,
         request: state.request,
       };
@@ -297,6 +312,7 @@ const reducer = (state: State, e: Event): State => {
         derivation: null,
         displayUpgradeWarning: false,
         unresponsive: false,
+        isLocked: false,
         allowOpeningGranted: false,
         allowOpeningRequestedWording: null,
         allowManagerGranted: false,
@@ -317,6 +333,7 @@ const reducer = (state: State, e: Event): State => {
         derivation: null,
         displayUpgradeWarning: false,
         unresponsive: false,
+        isLocked: false,
         allowOpeningGranted: true,
         allowOpeningRequestedWording: null,
         allowManagerGranted: true,
@@ -336,6 +353,7 @@ const reducer = (state: State, e: Event): State => {
         displayUpgradeWarning: false,
         isLoading: false,
         unresponsive: false,
+        isLocked: false,
         allowOpeningGranted: false,
         allowOpeningRequestedWording: null,
         allowManagerGranted: false,
@@ -360,6 +378,7 @@ const reducer = (state: State, e: Event): State => {
         error: null,
         isLoading: false,
         unresponsive: false,
+        isLocked: false,
         opened: true,
         appAndVersion: e.app,
         derivation: e.derivation,
@@ -563,7 +582,7 @@ const implementations = {
 
 export let currentMode: keyof typeof implementations = "event";
 
-export function setDeviceMode(mode: keyof typeof implementations) {
+export function setDeviceMode(mode: keyof typeof implementations): void {
   currentMode = mode;
 }
 

libs/ledger-live-common/src/hw/actions/manager.ts

@@ -47,6 +47,7 @@ type State = {
   deviceInfo: DeviceInfo | null | undefined;
   result: ListAppsResult | null | undefined;
   error: Error | null | undefined;
+  isLocked: boolean;
 };
 
 type ManagerState = State & {
@@ -101,6 +102,7 @@ const getInitialState = (device?: Device | null | undefined): State => ({
   isLoading: !!device,
   requestQuitApp: false,
   unresponsive: false,
+  isLocked: false,
   allowManagerRequestedWording: null,
   allowManagerGranted: false,
   device,
@@ -114,6 +116,9 @@ const reducer = (state: State, e: Event): State => {
     case "unresponsiveDevice":
       return { ...state, unresponsive: true };
 
+    case "lockedDevice":
+      return { ...state, isLocked: true };
+
     case "deviceChange":
       return getInitialState(e.device);
 
@@ -122,17 +127,24 @@ const reducer = (state: State, e: Event): State => {
         ...getInitialState(state.device),
         error: e.error,
         isLoading: false,
+        isLocked: false,
       };
 
     case "appDetected":
-      return { ...state, unresponsive: false, requestQuitApp: true };
+      return {
+        ...state,
+        unresponsive: false,
+        isLocked: false,
+        requestQuitApp: true,
+      };
 
     case "osu":
     case "bootloader":
       return {
         ...state,
         isLoading: false,
         unresponsive: false,
+        isLocked: false,
         requestQuitApp: false,
         deviceInfo: e.deviceInfo,
       };
@@ -142,20 +154,23 @@ const reducer = (state: State, e: Event): State => {
         ...state,
         requestQuitApp: false,
         unresponsive: false,
+        isLocked: false,
         deviceInfo: e.deviceInfo,
       };
 
     case "device-permission-requested":
       return {
         ...state,
         unresponsive: false,
+        isLocked: false,
         allowManagerRequestedWording: e.wording,
       };
 
     case "device-permission-granted":
       return {
         ...state,
         unresponsive: false,
+        isLocked: false,
         allowManagerRequestedWording: null,
         allowManagerGranted: true,
       };
@@ -165,6 +180,7 @@ const reducer = (state: State, e: Event): State => {
         ...state,
         isLoading: false,
         unresponsive: false,
+        isLocked: false,
         result: e.result,
       };
   }
@@ -312,6 +328,7 @@ const implementations = {
       };
     }).pipe(distinctUntilChanged(isEqual)),
 };
+
 export const createAction = (
   connectManagerExec: (
     arg0: ConnectManagerInput
@@ -349,6 +366,7 @@ export const createAction = (
     const [state, setState] = useState(() => getInitialState(device));
     const [resetIndex, setResetIndex] = useState(0);
     const deviceSubject = useReplaySubject(device);
+
     useEffect(() => {
       const impl = implementations[currentMode]({
         deviceSubject,
@@ -378,6 +396,7 @@ export const createAction = (
         sub.unsubscribe();
       };
     }, [deviceSubject, resetIndex, repairModalOpened, managerRequest]);
+
     const { deviceInfo } = state;
     useEffect(() => {
       if (!deviceInfo) return;

libs/ledger-live-common/src/hw/actions/types.ts

@@ -1,11 +1,17 @@
 import type { DeviceModelId } from "@ledgerhq/devices";
+
 export type Device = {
   deviceId: string;
   deviceName?: string | null;
   modelId: DeviceModelId;
   wired: boolean;
 };
+
 export type Action<Request, HookState, Result> = {
   useHook: (arg0: Device | null | undefined, arg1: Request) => HookState;
   mapResult: (arg0: HookState) => Result | null | undefined;
 };
+
+export type LockedDeviceEvent = {
+  type: "lockedDevice";
+};