Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: FAT-462 LLM handle 0x5515 response for basic device actions #1685

Merged
merged 8 commits into from
Nov 2, 2022

Conversation

alexandremgo
Copy link
Contributor

@alexandremgo alexandremgo commented Oct 26, 2022

πŸ“ Description

πŸ‘‰ Only for LLM as LLD currently uses the "event" mode for device actions.

Fixed new 0x5515 response in the 2 cases:

  • allow manager device action
  • connect app device action

βœ‹ Currently targeting support/fix-llm-ts for the types, but will be merged on develop.

🧼 Also tried to do some cleaning on the status codes, but the definition of StatusCodes is not exhaustive (see here if you want to double check the values)

Note: you should review this PR by commit, it will be way easier and quicker

❓ Context

  • Impacted projects: LLM and live-common
  • Linked resource(s): FAT-462 and FAT-590

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

See Slack

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@alexandremgo alexandremgo requested review from a team as code owners October 26, 2022 13:00
@alexandremgo alexandremgo requested a review from a team October 26, 2022 13:00
@vercel
Copy link

vercel bot commented Oct 26, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 2, 2022 at 2:14PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 2, 2022 at 2:14PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 2, 2022 at 2:14PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 2, 2022 at 2:14PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022

πŸ¦‹ Changeset detected

Latest commit: ae03ece

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
live-mobile Patch
@ledgerhq/live-common Patch
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added automation CI/CD stuff cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM tools Has changes in tools translations Translation files have been touched ui Has changes in the design system library labels Oct 26, 2022
@alexandremgo alexandremgo force-pushed the support/LLM-FAT-462-handle-5515-response branch from ef7f2e6 to 7d83e07 Compare October 26, 2022 13:04
@github-actions github-actions bot removed ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli translations Translation files have been touched desktop Has changes in LLD automation CI/CD stuff ui Has changes in the design system library labels Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 47.95% // Head: 47.94% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (babfc59) compared to base (f2c27ec).
Patch coverage: 25.00% of modified lines in pull request are covered.

❗ Current head babfc59 differs from pull request most recent head ae03ece. Consider uploading reports for the commit ae03ece to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1685      +/-   ##
===========================================
- Coverage    47.95%   47.94%   -0.01%     
===========================================
  Files          691      691              
  Lines        30456    30458       +2     
  Branches      7989     7966      -23     
===========================================
  Hits         14604    14604              
- Misses       14638    15790    +1152     
+ Partials      1214       64    -1150     
Flag Coverage Ξ”
test 47.94% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/hw/actions/app.ts 10.29% <25.00%> (-0.11%) ⬇️
libs/ledger-live-common/src/env.ts 74.50% <0.00%> (ΓΈ)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ΓΈ)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ΓΈ)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ΓΈ)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ΓΈ)
... and 259 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to pretend I understood everything as I'm not familiar with a lot of the device interaction logic but I didn't see anything that seemed wrong.

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

@alexandremgo

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants