-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support: FAT-462 LLM handle 0x5515 response for basic device actions #1685
Support: FAT-462 LLM handle 0x5515 response for basic device actions #1685
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: ae03ece The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ef7f2e6
to
7d83e07
Compare
842b94e
to
a69cfbc
Compare
Codecov ReportBase: 47.95% // Head: 47.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1685 +/- ##
===========================================
- Coverage 47.95% 47.94% -0.01%
===========================================
Files 691 691
Lines 30456 30458 +2
Branches 7989 7966 -23
===========================================
Hits 14604 14604
- Misses 14638 15790 +1152
+ Partials 1214 64 -1150
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
3f6c6be
to
17b20b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to pretend I understood everything as I'm not familiar with a lot of the device interaction logic but I didn't see anything that seemed wrong.
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
5256fb5
to
3c89ed5
Compare
05f98ae
to
b26fd81
Compare
7cc6825
to
ae03ece
Compare
π Description
π Only for LLM as LLD currently uses the "event" mode for device actions.
Fixed new 0x5515 response in the 2 cases:
β Currently targeting
support/fix-llm-ts
for the types, but will be merged ondevelop
.π§Ό Also tried to do some cleaning on the status codes, but the definition of
StatusCodes
is not exhaustive (see here if you want to double check the values)Note: you should review this PR by commit, it will be way easier and quicker
β Context
β Checklist
πΈ Demo
See Slack
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.