Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: BLE pairing flow imports and names #1143

Merged
merged 6 commits into from
Sep 2, 2022

Conversation

alexandremgo
Copy link
Contributor

πŸ“ Description

Fixes on:

  • bad import for TransportListen
  • type for PathToDeviceParam

Feat:

  • choice of navigation type: replace or navigate

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 1, 2022 at 3:32PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 1, 2022 at 3:32PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 1, 2022 at 3:32PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 1, 2022 at 3:32PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2022

πŸ¦‹ Changeset detected

Latest commit: d072f40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1143 (d072f40) into develop (0f60c43) will decrease coverage by 2.83%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1143      +/-   ##
===========================================
- Coverage    47.84%   45.00%   -2.84%     
===========================================
  Files          650      590      -60     
  Lines        29121    25906    -3215     
  Branches      7532     6922     -610     
===========================================
- Hits         13932    11660    -2272     
+ Misses       15131    14195     -936     
+ Partials        58       51       -7     
Flag Coverage Ξ”
test 45.00% <ΓΈ> (-2.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...edgerjs/packages/hw-app-btc/tests/newops/testtx.ts
...s/ledgerjs/packages/cryptoassets/src/currencies.ts
.../ledgerjs/packages/hw-app-btc/src/newops/merkle.ts
...dgerjs/packages/hw-app-btc/src/splitTransaction.ts
libs/ledgerjs/packages/cryptoassets/data/trc10.js
.../ledgerjs/packages/hw-app-btc/src/newops/policy.ts
...dgerjs/packages/hw-app-btc/src/newops/appClient.ts
...s/hw-transport-mocker/src/openTransportReplayer.ts
libs/ledgerjs/packages/hw-app-helium/src/Helium.ts
...dgerjs/packages/hw-app-helium/src/serialization.ts
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

@alexandremgo

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@grsoares21 grsoares21 merged commit 5f15da1 into develop Sep 2, 2022
@grsoares21 grsoares21 deleted the support/BlePairingFlow_importsAndNames branch September 2, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants