Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar & topbar over walletconnect #1312

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

Justkant
Copy link
Contributor

📝 Description

A switch for the walletconnect screen was removed in the PR #593

Behaves in the same way as before: https://github.com/LedgerHQ/ledger-live/pull/593/files#diff-ba34fac6b14664d7b6de0efeec9da7d00f2294fb582e321af7d362db84453bf2R198

❓ Context

  • Impacted projects: live-desktop
  • Linked resource(s): ``

✅ Checklist

  • Test coverage: tested manually, we should probably add a screenshot test for this (requires some mocking of the session)
  • Atomic delivery
  • No breaking changes

📸 Demo

Before:
Screenshot 2022-09-19 at 16 29 58

After:
Screenshot 2022-09-19 at 16 44 48

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 2:53PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 19, 2022 at 2:53PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 19, 2022 at 2:53PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 19, 2022 at 2:53PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

🦋 Changeset detected

Latest commit: ddc3a8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the desktop Has changes in LLD label Sep 19, 2022
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🚀

@github-actions
Copy link

@Justkant

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@Justkant Justkant merged commit 13301bf into develop Sep 19, 2022
@Justkant Justkant deleted the bugfix/walletconnect-LLD branch September 19, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants