Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/migrate v3 onboarding #593

Merged
merged 102 commits into from
Sep 5, 2022
Merged

Conversation

pierrelouis-c
Copy link
Contributor

@pierrelouis-c pierrelouis-c commented Jul 6, 2022

πŸ“ Description

Migrate v3 onboarding to the main repository
Figma Link

❓ Context

  • Impacted projects: ledger-live-desktop
  • Linked resource(s): FAT-104 FAT-227

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

simplescreenrecorder-2022-07-15_11.28.09.mp4

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Jul 6, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 2, 2022 at 4:37PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 2, 2022 at 4:37PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 2, 2022 at 4:37PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 2, 2022 at 4:37PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2022

πŸ¦‹ Changeset detected

Latest commit: 6e33e62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #593 (1c30b42) into develop (f5a9e2f) will increase coverage by 4.70%.
The diff coverage is n/a.

❗ Current head 1c30b42 differs from pull request most recent head 6e33e62. Consider uploading reports for the commit 6e33e62 to get more accurate results

@@             Coverage Diff             @@
##           develop     #593      +/-   ##
===========================================
+ Coverage    43.14%   47.84%   +4.70%     
===========================================
  Files          572      650      +78     
  Lines        24416    29121    +4705     
  Branches      6633     7532     +899     
===========================================
+ Hits         10534    13933    +3399     
- Misses       13837    15130    +1293     
- Partials        45       58      +13     
Flag Coverage Ξ”
test 47.84% <ΓΈ> (+4.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/hw-app-btc/src/BtcNew.ts 92.25% <0.00%> (ΓΈ)
.../ledgerjs/packages/hw-app-btc/src/newops/merkle.ts 83.82% <0.00%> (ΓΈ)
...ckages/hw-app-btc/tests/newops/integrationtools.ts 92.03% <0.00%> (ΓΈ)
...dgerjs/packages/cryptoassets/data/polygon-erc20.js 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-btc/src/varint.ts 30.76% <0.00%> (ΓΈ)
...ibs/ledgerjs/packages/hw-app-algorand/src/utils.ts 38.88% <0.00%> (ΓΈ)
...ages/hw-app-eth/src/modules/EIP712/EIP712.utils.ts 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts 78.13% <0.00%> (ΓΈ)
.../ledgerjs/packages/hw-app-btc/src/newops/policy.ts 91.66% <0.00%> (ΓΈ)
...ledgerjs/packages/hw-transport-mocker/src/index.ts 100.00% <0.00%> (ΓΈ)
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Jul 12, 2022

@pierrelouis-c

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Copy link
Contributor

@grsoares21 grsoares21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't be scared by the quantity of comments.

It's mainly some questions and details. I didn't see any major issues except for one thing:
There are way too many styled components that could have been just simple Design System components with the correct props.
Ideally we shouldn't need any custom CSS on LLD anymore, not for V3. This probably won't be always possible but we should always do it whenever it is.
I understand this is the accumulation of several people's work, so most of those aren't even yours. And I don't want to delay the merge of this PR any more than we have to. But I do think we should tackle this ASAP as a team. Otherwise they will just multiply due to the chameleon rule.

`;

const NanoSP = styled.div`
// TODO: rendering issue in the SVG in the "hole"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what this means? was it fixed? can you put maybe a more explicit comment about what the issue is?

@pierrelouis-c
Copy link
Contributor Author

/generate-screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD screenshots Screenshots have been updated translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants