Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize headers and pixel polish LLM sync onboarding #1486

Merged
merged 10 commits into from
Oct 14, 2022

Conversation

thomasrogerlux
Copy link
Contributor

πŸ“ Description

Create a new SyncOnboardingView component used as a container for all the new onboarding screens, allowing for an unified look and simplification of the code.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): N/A

βœ… Checklist

  • Test coverage: no UI testing on mobile yet
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

N/A, see proper slack channels

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 6, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 13, 2022 at 3:25PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 13, 2022 at 3:25PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 3:25PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 13, 2022 at 3:25PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022

πŸ¦‹ Changeset detected

Latest commit: cbbbb58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 43.22% // Head: 43.30% // Increases project coverage by +0.07% πŸŽ‰

Coverage data is based on head (cbbbb58) compared to base (0f1bf87).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1486      +/-   ##
===========================================
+ Coverage    43.22%   43.30%   +0.07%     
===========================================
  Files          618      616       -2     
  Lines        26026    25867     -159     
  Branches      7053     7026      -27     
===========================================
- Hits         11251    11202      -49     
- Misses       13632    14597     +965     
+ Partials      1143       68    -1075     
Flag Coverage Ξ”
test 43.30% <ΓΈ> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/env.ts 80.43% <0.00%> (ΓΈ)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ΓΈ)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ΓΈ)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ΓΈ)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ΓΈ)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ΓΈ)
libs/ledger-live-common/src/apps/logic.ts 89.71% <0.00%> (ΓΈ)
... and 242 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

@thomasrogerlux

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

@thomasrogerlux thomasrogerlux force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch from 70cb9d1 to 76d07e1 Compare October 6, 2022 14:35
@thomasrogerlux thomasrogerlux requested a review from a team as a code owner October 6, 2022 14:35
@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch 2 times, most recently from 6277f05 to f9426bd Compare October 10, 2022 13:29
@alexandremgo alexandremgo force-pushed the feat/FAT-82-LLM-new-onboarding-flow branch 3 times, most recently from cc643b3 to 82b71c8 Compare October 12, 2022 10:55
Base automatically changed from feat/FAT-82-LLM-new-onboarding-flow to develop October 12, 2022 12:12
Copy link
Contributor

@alexandremgo alexandremgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:beautiful:

@vercel
Copy link

vercel bot commented Oct 13, 2022

Deployment failed with the following error:

Creating the Deployment Timed Out.

@thomasrogerlux thomasrogerlux merged commit 10984d0 into develop Oct 14, 2022
@thomasrogerlux thomasrogerlux deleted the support/FAT-82-code-refactor branch October 14, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants