Bugfix/live 4308 "Language" row bad layout in My Ledger #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ee9bb86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
cli
common
Codecov ReportBase: 44.77% // Head: 44.77% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## release #1623 +/- ##
========================================
Coverage 44.77% 44.77%
========================================
Files 633 633
Lines 26653 26653
Branches 7228 7228
========================================
Hits 11934 11934
Misses 13576 13576
Partials 1143 1143
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
github-actions
bot
removed
tools
alexandremgo
approved these changes
Oct 19, 2022
mcayuelas-ledger
approved these changes
Oct 20, 2022
valpinkman
added a commit
that referenced
this pull request
Nov 2, 2022
* release: (251 commits) 🚀 prepare release [skip ci] Smartling on-demand translation delivery from release (#1722) chore: bump lld chore(fix): doc:ljs and pods update update release note 🚀 release prerelease [LLM(3.10.0-next.4)] add changeset 🚀 entering LLD hotfix mode Fix/LIVE-4302 - Fix update firmware notif breaking layout (#1624) 🚀 release prerelease [LLM(3.10.0-next.3)] Bugfix: LIVE-4305 new rendering in the case of a LatestFirmwareVersionRequired error (#1648) 🚀 release prerelease [LLM(3.10.0-next.2)] Fix: Live-4319 MyLedger tab logo dot condition (#1633) 🚀 release prerelease [LLM(3.10.0-next.1)] Bugfix/live 4308 "Language" row bad layout in My Ledger (#1623) 🚀 release prerelease [LLM(3.10.0-next.0)] 🚀 entering LLM prerelease mode [LIVE-4283] - Bugfix: Update getFeesEstimation for EVM to prevent usage of `getFeeData` (#1603) chore: remove npm bump fixes bot workflow dispatch ...
valpinkman
added a commit
that referenced
this pull request
Nov 2, 2022
* release: (49 commits) 🚀 prepare release [skip ci] Smartling on-demand translation delivery from release (#1722) chore: bump lld chore(fix): doc:ljs and pods update update release note 🚀 release prerelease [LLM(3.10.0-next.4)] add changeset 🚀 entering LLD hotfix mode Fix/LIVE-4302 - Fix update firmware notif breaking layout (#1624) 🔥 hotfix release [skip ci] 🚀 release prerelease [LLM(3.10.0-next.3)] Bugfix: LIVE-4305 new rendering in the case of a LatestFirmwareVersionRequired error (#1648) 🚀 release prerelease [LLM(3.10.0-next.2)] Fix: Live-4319 MyLedger tab logo dot condition (#1633) 🔥 hotfix prerelease [LLD(2.49.1-hotfix.0)] [LIVE-4283] Hotfix - Update getFeesEstimation for EVM to prevent usage of getFeeData (#1620) 🚀 release prerelease [LLM(3.10.0-next.1)] Bugfix/live 4308 "Language" row bad layout in My Ledger (#1623) 🚀 entering LLD hotfix mode chore: remove npm bump ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
There was a flex issue in the My Ledger screen where the "Language" option for a device was not properly displayed.
Fixed it & extracted the component "DeviceOptionRow" for other existing options.
❓ Context
ledger-live-mobile✅ Checklist
📸 Demo
fix-myledger-loc-button.mp4
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.