Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Live-4319 MyLedger tab logo dot condition #1633

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Conversation

alexandremgo
Copy link
Contributor

@alexandremgo alexandremgo commented Oct 20, 2022

πŸ“ Description

The dot to signal a new app update had a incorrect display condition - fixed it

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): jira

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 20, 2022 at 0:06AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 20, 2022 at 0:06AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 20, 2022 at 0:06AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 20, 2022 at 0:06AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022

πŸ¦‹ Changeset detected

Latest commit: d1c5f87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Oct 20, 2022
@github-actions
Copy link

@alexandremgo

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@alexandremgo alexandremgo merged commit 269185c into release Oct 20, 2022
@alexandremgo alexandremgo deleted the bugfix/LIVE-4319 branch October 20, 2022 15:07
valpinkman added a commit that referenced this pull request Nov 2, 2022
* release: (251 commits)
  πŸš€ prepare release [skip ci]
  Smartling on-demand translation delivery from release (#1722)
  chore: bump lld
  chore(fix): doc:ljs and pods update
  update release note
  πŸš€ release prerelease [LLM(3.10.0-next.4)]
  add changeset
  πŸš€ entering LLD hotfix mode
  Fix/LIVE-4302 - Fix update firmware notif breaking layout (#1624)
  πŸš€ release prerelease [LLM(3.10.0-next.3)]
  Bugfix: LIVE-4305 new rendering in the case of a LatestFirmwareVersionRequired error (#1648)
  πŸš€ release prerelease [LLM(3.10.0-next.2)]
  Fix: Live-4319 MyLedger tab logo dot condition (#1633)
  πŸš€ release prerelease [LLM(3.10.0-next.1)]
  Bugfix/live 4308 "Language" row bad layout in My Ledger (#1623)
  πŸš€ release prerelease [LLM(3.10.0-next.0)]
  πŸš€ entering LLM prerelease mode
  [LIVE-4283] - Bugfix: Update getFeesEstimation for EVM to prevent usage of `getFeeData` (#1603)
  chore: remove npm bump
  fixes bot workflow dispatch
  ...
valpinkman added a commit that referenced this pull request Nov 2, 2022
* release: (49 commits)
  πŸš€ prepare release [skip ci]
  Smartling on-demand translation delivery from release (#1722)
  chore: bump lld
  chore(fix): doc:ljs and pods update
  update release note
  πŸš€ release prerelease [LLM(3.10.0-next.4)]
  add changeset
  πŸš€ entering LLD hotfix mode
  Fix/LIVE-4302 - Fix update firmware notif breaking layout (#1624)
  πŸ”₯ hotfix release [skip ci]
  πŸš€ release prerelease [LLM(3.10.0-next.3)]
  Bugfix: LIVE-4305 new rendering in the case of a LatestFirmwareVersionRequired error (#1648)
  πŸš€ release prerelease [LLM(3.10.0-next.2)]
  Fix: Live-4319 MyLedger tab logo dot condition (#1633)
  πŸ”₯ hotfix prerelease [LLD(2.49.1-hotfix.0)]
  [LIVE-4283] Hotfix - Update getFeesEstimation for EVM to prevent usage of getFeeData (#1620)
  πŸš€ release prerelease [LLM(3.10.0-next.1)]
  Bugfix/live 4308 "Language" row bad layout in My Ledger (#1623)
  πŸš€ entering LLD hotfix mode
  chore: remove npm bump
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants