[LIVE-12107/LIVE-11325][LLD/LLM][Sync onboarding] Recover backup entry point #6645

ofreyssinet-ledger · 2024-04-10T08:37:21Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- LLD Sync onboarding
- React UI: Tag component

📝 Description

LLD: Add a step "Backup with recover or keep manual backup of seed" in the sync onboarding. Cf. video below.
react-ui: Tag component: add "tiny" size, fix paddings that were too big.

backup.lld.mov

with the correct redirection in Recover app:

backup.recover.mov

❓ Context

JIRA or GitHub link: LIVE-12107 LIVE-11325

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-04-10T08:37:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Apr 22, 2024 3:41pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Apr 22, 2024 3:41pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Apr 22, 2024 3:41pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Apr 22, 2024 3:41pm
web-tools	⬜️ Ignored (Inspect)	Visit Preview	Apr 22, 2024 3:41pm

ofreyssinet-ledger · 2024-04-10T15:34:41Z

apps/ledger-live-desktop/src/renderer/components/ButtonV3.tsx

@@ -12,10 +12,7 @@ export const Base = styled(BaseButton)<{ big?: boolean }>`
  line-height: 40px;
  padding: 0 24px;

-  ${p =>
-    p.variant === "shade"
-      ? `background-color: transparent!important;border-color: currentColor;`


the border color override here was not matching the design

jdabbech-ledger · 2024-04-19T09:09:49Z

libs/ui/packages/react/src/components/Tag/index.tsx

    case "large":
    default:
-      return "9px 10px 10px";
+      return "8px 9px 9px";


that could be a reason why e2e tests fail @mbertin-ledger

jdabbech-ledger · 2024-04-19T09:51:14Z

@jdabbech-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

feat(llm/synconboarding): backup seed navigation fix(llm/synconboarding): imports fix(llm/synconboarding): params feat(llm/SyncOnboarding): backup analytics fix(llm/synconboarding/backup): Recover upsell redirection

ofreyssinet-ledger · 2024-04-22T12:34:19Z

@ofreyssinet-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

mcayuelas-ledger

Just console.log to remove

apps/ledger-live-desktop/src/storyly/useStoryly.tsx

ofreyssinet-ledger · 2024-04-22T13:58:02Z

@ofreyssinet-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

…on-reviews 💄 (lld/llm) [12240] Copy for recover during onboarding flow to be updated to latest version

jiyuzhuang · 2024-04-22T15:12:41Z

apps/ledger-live-desktop/src/renderer/components/SyncOnboarding/Manual/BackupStep.tsx

+  color: "neutral.c70",
+})``;
+
+const VideoLink = () => {


Suggested change

const VideoLink = () => {

const VideoLink: React.FC<void> = () => {

jiyuzhuang · 2024-04-22T15:15:22Z

apps/ledger-live-desktop/src/renderer/components/SyncOnboarding/Manual/BackupStep.tsx

+const BackupStep: React.FC<Props> = props => {
+  const { device, onPressKeepManualBackup } = props;


Suggested change

const BackupStep: React.FC<Props> = props => {

const { device, onPressKeepManualBackup } = props;

const BackupStep: React.FC<Props> =({ device, onPressKeepManualBackup }) => {

In addition, I think that it's better to rename the props by BackupStepProps to avoid a common Props as there is more than one component in the same file.

jiyuzhuang · 2024-04-22T15:17:33Z

apps/ledger-live-mobile/src/screens/SyncOnboarding/companionSteps/BackupStep.tsx

+  color: "neutral.c70",
+})``;
+
+const VideoLink = ({ onPress }: { onPress(): void }) => {


Suggested change

const VideoLink = ({ onPress }: { onPress(): void }) => {

type VideoLinkProps = { onPress(): void; };

const VideoLink: React.FC<VideoLinkProps> = ({ onPress }) => {

jiyuzhuang · 2024-04-22T15:18:34Z

apps/ledger-live-mobile/src/screens/SyncOnboarding/companionSteps/BackupStep.tsx

+  },
+];
+
+const BackupStep: React.FC<Props> = props => {


Same with this comment.

cksanders · 2024-04-23T12:17:08Z

Resolves https://ledgerhq.atlassian.net/browse/PROTECT-3039

github-actions bot assigned ofreyssinet-ledger Apr 10, 2024

live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched ui Has changes in the design system library labels Apr 10, 2024

ofreyssinet-ledger commented Apr 10, 2024

View reviewed changes

ofreyssinet-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch from feaf45b to 91b8256 Compare April 12, 2024 12:40

jdabbech-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch from 91b8256 to 39278f3 Compare April 18, 2024 14:59

jdabbech-ledger added the live-devices Device team label label Apr 18, 2024

jdabbech-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch 2 times, most recently from eefe393 to cca171e Compare April 18, 2024 15:11

mbertin-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch from 5a89aed to 5fdf0ee Compare April 19, 2024 08:49

mbertin-ledger changed the title ~~[LIVE-12107][LLD][Sync onboarding] Recover backup entry point~~ [LIVE-12107/LIVE-11325][LLD/LLM][Sync onboarding] Recover backup entry point Apr 19, 2024

mbertin-ledger marked this pull request as ready for review April 19, 2024 08:51

mbertin-ledger requested review from a team as code owners April 19, 2024 08:51

jdabbech-ledger reviewed Apr 19, 2024

View reviewed changes

ofreyssinet-ledger requested a review from a team as a code owner April 19, 2024 09:57

live-github-bot bot added the screenshots Screenshots have been updated label Apr 19, 2024

jdabbech-ledger previously approved these changes Apr 19, 2024

View reviewed changes

ofreyssinet-ledger added 6 commits April 22, 2024 12:42

feat(llm/StorylyStories): add custom rendering logic

bdb331a

feat(llm/synconboarding): backup seed step wip

8af9560

feat(llm/synconboarding): backup seed navigation fix(llm/synconboarding): imports fix(llm/synconboarding): params feat(llm/SyncOnboarding): backup analytics fix(llm/synconboarding/backup): Recover upsell redirection

fix(llm/synconboarding): add todos, fix storyly props

93112f0

style(llm): fix lint

604f272

chore: changeset

3b0d18a

fix(llm/synconboarding): condition to go to backup step

5f5a0e1

test(lld): update screenshots (ubuntu-latest) lld, test, screenshot

cd85eee

live-github-bot bot and others added 3 commits April 22, 2024 12:41

test(lld): update screenshots (ubuntu-latest) lld, test, screenshot

f558546

💄 fix(llm): Backup companion refinements

9729cb9

💄 fix(lld): Backup companion step refinements

7f5fb20

mcayuelas-ledger previously approved these changes Apr 22, 2024

View reviewed changes

apps/ledger-live-desktop/src/storyly/useStoryly.tsx Outdated Show resolved Hide resolved

apps/ledger-live-desktop/src/storyly/useStoryly.tsx Outdated Show resolved Hide resolved

chore: cleanup console.log

a0f2dfa

ofreyssinet-ledger dismissed mcayuelas-ledger’s stale review via a0f2dfa April 22, 2024 13:56

ofreyssinet-ledger force-pushed the feat/LIVE-12107-lld-synconboarding-recover-backup branch from f558546 to a0f2dfa Compare April 22, 2024 13:56

mcayuelas-ledger previously approved these changes Apr 22, 2024

View reviewed changes

test(lld): update screenshots (ubuntu-latest) lld, test, screenshot

8d020d3

live-github-bot bot dismissed mcayuelas-ledger’s stale review via 8d020d3 April 22, 2024 14:06

Merge pull request #6709 from LedgerHQ/feat/LIVE-12240-backup-compani…

7dda085

…on-reviews 💄 (lld/llm) [12240] Copy for recover during onboarding flow to be updated to latest version

jiyuzhuang reviewed Apr 22, 2024

View reviewed changes

mcayuelas-ledger previously approved these changes Apr 22, 2024

View reviewed changes

jiyuzhuang reviewed Apr 22, 2024

View reviewed changes

style(llm/lld/synconboarding): typing

71d7cbd

ofreyssinet-ledger dismissed mcayuelas-ledger’s stale review via 71d7cbd April 22, 2024 15:28

jiyuzhuang previously approved these changes Apr 22, 2024

View reviewed changes

fix(lld): typing

8a4c906

ofreyssinet-ledger dismissed jiyuzhuang’s stale review via 8a4c906 April 22, 2024 15:40

jdabbech-ledger approved these changes Apr 23, 2024

View reviewed changes

mcayuelas-ledger approved these changes Apr 23, 2024

View reviewed changes

lduchemin-ledger approved these changes Apr 23, 2024

View reviewed changes

ofreyssinet-ledger merged commit d4135f1 into develop Apr 23, 2024
53 of 55 checks passed

ofreyssinet-ledger deleted the feat/LIVE-12107-lld-synconboarding-recover-backup branch April 23, 2024 09:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LIVE-12107/LIVE-11325][LLD/LLM][Sync onboarding] Recover backup entry point #6645

[LIVE-12107/LIVE-11325][LLD/LLM][Sync onboarding] Recover backup entry point #6645

ofreyssinet-ledger commented Apr 10, 2024 •

edited

Loading

vercel bot commented Apr 10, 2024 •

edited

Loading

ofreyssinet-ledger Apr 10, 2024

jdabbech-ledger Apr 19, 2024

jdabbech-ledger commented Apr 19, 2024 •

edited by live-github-bot bot

Loading

ofreyssinet-ledger commented Apr 22, 2024 •

edited by live-github-bot bot

Loading

mcayuelas-ledger left a comment

ofreyssinet-ledger commented Apr 22, 2024 •

edited by live-github-bot bot

Loading

jiyuzhuang Apr 22, 2024

jiyuzhuang Apr 22, 2024

jiyuzhuang Apr 22, 2024

jiyuzhuang Apr 22, 2024

cksanders commented Apr 23, 2024

	const VideoLink = () => {
	const VideoLink: React.FC<void> = () => {

		const BackupStep: React.FC<Props> = props => {
		const { device, onPressKeepManualBackup } = props;

	const BackupStep: React.FC<Props> = props => {
	const { device, onPressKeepManualBackup } = props;
	const BackupStep: React.FC<Props> =({ device, onPressKeepManualBackup }) => {

-const VideoLink = ({ onPress }: { onPress(): void }) => {
+type VideoLinkProps = { onPress(): void; };
+const VideoLink: React.FC<VideoLinkProps> = ({ onPress }) => {

[LIVE-12107/LIVE-11325][LLD/LLM][Sync onboarding] Recover backup entry point #6645

[LIVE-12107/LIVE-11325][LLD/LLM][Sync onboarding] Recover backup entry point #6645

Conversation

ofreyssinet-ledger commented Apr 10, 2024 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 10, 2024 • edited Loading

ofreyssinet-ledger Apr 10, 2024

Choose a reason for hiding this comment

jdabbech-ledger Apr 19, 2024

Choose a reason for hiding this comment

jdabbech-ledger commented Apr 19, 2024 • edited by live-github-bot bot Loading

ofreyssinet-ledger commented Apr 22, 2024 • edited by live-github-bot bot Loading

mcayuelas-ledger left a comment

Choose a reason for hiding this comment

ofreyssinet-ledger commented Apr 22, 2024 • edited by live-github-bot bot Loading

jiyuzhuang Apr 22, 2024

Choose a reason for hiding this comment

jiyuzhuang Apr 22, 2024

Choose a reason for hiding this comment

jiyuzhuang Apr 22, 2024

Choose a reason for hiding this comment

jiyuzhuang Apr 22, 2024

Choose a reason for hiding this comment

cksanders commented Apr 23, 2024

ofreyssinet-ledger commented Apr 10, 2024 •

edited

Loading

vercel bot commented Apr 10, 2024 •

edited

Loading

jdabbech-ledger commented Apr 19, 2024 •

edited by live-github-bot bot

Loading

ofreyssinet-ledger commented Apr 22, 2024 •

edited by live-github-bot bot

Loading

ofreyssinet-ledger commented Apr 22, 2024 •

edited by live-github-bot bot

Loading