Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cvs): upgrade to v3 API for fetchSupportedFiatsTokens() #6768

Closed
wants to merge 1 commit into from

Conversation

gre
Copy link
Contributor

@gre gre commented Apr 26, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • list of fiats in countervalues settings

πŸ“ Description

this is a maintenance update from v2 to v3 API for fetching the supported fiats.

❓ Context

  • JIRA or GitHub link: LIVE-11862

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@gre gre requested review from a team as code owners April 26, 2024 16:01
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 29, 2024 7:50am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 29, 2024 7:50am
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 29, 2024 7:50am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 7:50am
react-ui-storybook ⬜️ Ignored (Inspect) Apr 29, 2024 7:50am

@gre gre closed this in #6771 May 6, 2024
@gre gre deleted the LIVE-11862 branch May 30, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants