CVS live-countervalues performance evolutions #6771

gre · 2024-04-29T10:43:04Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests. for most of them
Impact of the changes:
- countervalues

📝 Description

Implements https://ledgerhq.atlassian.net/browse/LIVE-11861 tasks
notably:

LIVE-11865: Add live-config fields
- they are provided as new fields in CountervaluesSettings so the live-countervalues lib don't directly depend on live-config but on LLD/LLM we will inject them from countervalues_*
switch refreshRate to 1min default (remote config)
- that way, the live price will be way more often up to date
LIVE-11864 introduce hybrid batch fetching mechanism
- that will improve the performance of frontend<>backend by reducing the amount of Cloudflare cache efficiency
switch from /v3/currencies/supported to /v3/supported/crypto
closes chore(cvs): upgrade to v3 API for fetchSupportedFiatsTokens() #6768

❓ Context

JIRA or GitHub link: LIVE-11865 LIVE-11864 LIVE-11862

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

- refresh rate - marketcap batching

vercel · 2024-04-29T10:43:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 2, 2024 3:48pm

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	May 2, 2024 3:48pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	May 2, 2024 3:48pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 2, 2024 3:48pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 2, 2024 3:48pm

LIVE-11864

jnicoulaud-ledger · 2024-05-02T06:17:33Z

libs/coin-framework/src/currencies/support.ts

@@ -72,7 +71,7 @@ async function initializeUserSupportedFiats() {

 export async function fetchSupportedFiatsTokens(): Promise<string[]> {
  try {
-    const response = await fetch(`${getEnv("LEDGER_COUNTERVALUES_API")}/v2/supported-to`, {
+    const response = await fetch(`${getEnv("LEDGER_COUNTERVALUES_API")}/v3/supported/fiat`, {


I thought we can't do this move yet because the market page does not support all the extra fiats until moved to /v3/markets API.

But when I tried on a build of this PR I still see the "short" list in the currency selection menu, so maybe I am missing something ?

@jnicoulaud-ledger

AFAIK market don't uses this function

the data of this API is currently crossed with hardcoded data: https://github.com/LedgerHQ/ledger-live/blob/develop/libs/ledgerjs/packages/cryptoassets/src/fiats.ts#L23 so it's possible that not all fiat appears yet. I can probably complete the list with the missing fiat data (but also indeed in future we would need a way to have this as an API if we don't want to maintain it statically)

Ha OK, that explains. But if my understanding is correct, market inherits the globally set currency so we are limited by what market supports.

For the harcoded data, I guess we could expose it in an API, but it's ISO-4217 standard, there are libraries that provide this metadata: https://www.npmjs.com/search?q=keywords:iso4217

@jnicoulaud-ledger #6798
for now, i think we can survive with this, especially we have some local modification needed for LL (e.g. using a shorter version for some fiat name to fit in the UI..)

i've merged the additions of fiats so we can test more. i seems to have a subset of fiat that all works on market. do you have a specific fiat that works on the new api but not on the old?

Yes, it's the diff between https://countervalues.live.ledger.com/v2/supported-to and https://countervalues.live.ledger.com/v3/supported/fiat, so for instance: AFN, ALL, AMD...

ok, after testing, i can confirm that market uses a totally different list , so we are fine with these changes. however, I had to do extra fix to actually make Live instance support the new list.

note for ourself: coin-framework also hardcode a locallySupportedFiats list, which i suspect market uses, so i'm not touching this, but in future we will need to move this out of coin-framework. ( cc @sprohaszka-ledger fyi )

I just tested again:

On prod build global currency and market are always synced

On this PR, market currency is always USD even if I set a global currency that is supported (EUR)

I would at least expect market currency to follow the global one when possible.

But also I remember last time this was discussed, it was considered not acceptable to have a different set of supported currencies globally and for market, so we might want to double check this ?

I would at least expect market currency to follow the global one when possible.

it doesn't seem it's the case today, and this PR didn't have the scope to address this. therefore if things are not connected i'm not sure if it's going to be a problem to have different list on both sides. indeed it's not ideal but i'm not seeing it a blocker to do this first step.
I'll ask product on monday.

seen with Anthony, we're good to have this evolution even if market is disconnected for the time being

chore: add all missing fiats (and apply fixes from currency changes)

…l list

hedi-edelbloute · 2024-05-03T13:20:19Z

libs/ledger-live-common/src/config/sharedConfig.ts

 const liveCommonConfig: ConfigSchema = {
  ...appConfig,
 };

 export const liveConfig: ConfigSchema = {
+  ...countervaluesConfig,


I think this can be a part of liveCommonConfig above, minor

the reasoning behind this is that "countervalues" is a dedicated library and not part of "live-common"

(ultimately the existence of this file that glue things together manually is problematic imo but it's another topic)

gre added 2 commits April 29, 2024 12:32

chore(countervalues): Add live-config fields

98750d9

- refresh rate - marketcap batching

chore(countervalues): switch refreshRate to 1min default (remote conf)

138bae7

gre requested review from a team as code owners April 29, 2024 10:43

github-actions bot assigned gre Apr 29, 2024

live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common cli labels Apr 29, 2024

gre marked this pull request as draft April 29, 2024 13:28

gre force-pushed the live-11861 branch from a870942 to c9a33c6 Compare April 29, 2024 14:20

gre marked this pull request as ready for review April 29, 2024 14:20

gre added 3 commits April 30, 2024 10:28

chore(countervalues): introduce hybrid batch fetching mecanism

04acd6f

LIVE-11864

chore(countervalues): switch to /v3/supported/crypto

5adf9d3

chore: changeset

5656cfc

gre force-pushed the live-11861 branch from c9a33c6 to 5656cfc Compare April 30, 2024 08:29

chore(cvs): upgrade to v3 API for fetchSupportedFiatsTokens()

9a7a798

gre requested a review from a team as a code owner April 30, 2024 08:31

vercel bot deployed to Preview – web-tools April 30, 2024 08:36 View deployment

vercel bot deployed to Preview – web-tools April 30, 2024 08:55 View deployment

jnicoulaud-ledger reviewed May 2, 2024

View reviewed changes

gre force-pushed the live-11861 branch from 40259df to 5f13563 Compare May 2, 2024 09:22

vercel bot had a problem deploying to Preview – web-tools May 2, 2024 09:24 Failure

gre force-pushed the live-11861 branch from 5f13563 to dc26589 Compare May 2, 2024 09:26

chore: remove useless log

5bd0d05

gre force-pushed the live-11861 branch from dc26589 to 5bd0d05 Compare May 2, 2024 09:27

gre added 2 commits May 2, 2024 11:28

chore: add all missing fiats (and apply fixes from currency changes)

83190a7

Merge pull request #6798 from LedgerHQ/live-12456

0999e74

chore: add all missing fiats (and apply fixes from currency changes)

live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label May 2, 2024

vercel bot had a problem deploying to Preview – web-tools May 2, 2024 09:32 Failure

vercel bot deployed to Preview – web-tools May 2, 2024 15:22 View deployment

chore: fix tests

166f80a

gre force-pushed the live-11861 branch from 843c6a3 to 166f80a Compare May 2, 2024 15:32

vercel bot deployed to Preview – web-tools May 2, 2024 15:36 View deployment

chore: fix fiat loading logic to handle new coins that aren't in loca…

63386e4

…l list

vercel bot deployed to Preview – web-tools May 2, 2024 15:48 View deployment

cgrellard-ledger approved these changes May 3, 2024

View reviewed changes

hedi-edelbloute approved these changes May 3, 2024

View reviewed changes

gre merged commit 6c35cc5 into develop May 6, 2024
57 of 58 checks passed

gre deleted the live-11861 branch May 6, 2024 08:28

gre mentioned this pull request May 6, 2024

chore: fix Firebase integration of CVS v3 rework #6811

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CVS live-countervalues performance evolutions #6771

CVS live-countervalues performance evolutions #6771

gre commented Apr 29, 2024 •

edited

Loading

vercel bot commented Apr 29, 2024 •

edited

Loading

jnicoulaud-ledger May 2, 2024 •

edited

Loading

gre May 2, 2024

jnicoulaud-ledger May 2, 2024

gre May 2, 2024 •

edited

Loading

gre May 2, 2024

jnicoulaud-ledger May 2, 2024

gre May 2, 2024

jnicoulaud-ledger May 2, 2024

gre May 3, 2024

gre May 6, 2024

hedi-edelbloute May 3, 2024

gre May 6, 2024

CVS live-countervalues performance evolutions #6771

CVS live-countervalues performance evolutions #6771

Conversation

gre commented Apr 29, 2024 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 29, 2024 • edited Loading

jnicoulaud-ledger May 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gre May 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gre commented Apr 29, 2024 •

edited

Loading

vercel bot commented Apr 29, 2024 •

edited

Loading

jnicoulaud-ledger May 2, 2024 •

edited

Loading

gre May 2, 2024 •

edited

Loading