-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LIVE-9638): change provider info from static object to API call #6853
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
39fab57
to
268c3e1
Compare
@@ -90,11 +90,15 @@ export async function fetchRates({ | |||
} | |||
|
|||
const url = new URL(`${getSwapAPIBaseURL()}/rate`); | |||
const providers = await getAvailableProviders(); | |||
if (removeProviders["moonpay"]) { | |||
providers.splice(providers.indexOf("moonpay"), 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it this moonpay coming from a Feature Flag or something, seems odd rn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nvm imo we should have it generic and loop on all keys of removeProviders
β Checklist
npx changeset
was attached.π Description
Change static provider info to an API call
β Context
https://ledgerhq.atlassian.net/browse/LIVE-9638
π§ Checklist for the PR Reviewers