Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(live-common/exchange): fix CAL service integration #6968

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

jnicoulaud-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • not covered by automatic tests => isofonctional change
  • Impact of the changes:
    • swap pane

πŸ“ Description

Followup of #6853:

  • fix internal URL used, bypassing Cloudflare cache
  • fix unused field requested
  • limit request to swap partners
  • add X-Ledger-Client-Version header for monitoring

image

I did not fix in this PR:

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

- fix internal URL used, bypassing Cloudflare cache
- fix unused field requested
- limit request to swap partners
- add X-Ledger-Client-Version header for monitoring
@jnicoulaud-ledger jnicoulaud-ledger requested a review from a team as a code owner May 29, 2024 18:17
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 30, 2024 0:56am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 0:56am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 0:56am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 0:56am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 0:56am

@live-github-bot live-github-bot bot added the common Has changes in live-common label May 29, 2024
lpaquet-ledger
lpaquet-ledger previously approved these changes May 30, 2024
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal change suggested: just replace the header by

"X-Ledger-Client-Version": getEnv("LEDGER_CLIENT_VERSION")

Copy link
Member

@CremaFR CremaFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I wasn't aware of this too
closing #6979

@lpaquet-ledger lpaquet-ledger requested a review from gre June 3, 2024 15:02
@jnicoulaud-ledger
Copy link
Contributor Author

@CremaFR @lpaquet-ledger (I don't have merge rights)

@lpaquet-ledger lpaquet-ledger merged commit c988a94 into develop Jun 11, 2024
58 checks passed
@lpaquet-ledger lpaquet-ledger deleted the bugfix/fix-swap-cal-service-partners-request branch June 11, 2024 08:01
kallen-ledger pushed a commit that referenced this pull request Jun 26, 2024
* fix(live-common/exchange): fix CAL service integration

- fix internal URL used, bypassing Cloudflare cache
- fix unused field requested
- limit request to swap partners
- add X-Ledger-Client-Version header for monitoring

* fix(live-common/exchange): replace fetch() with @ledgerhq/live-network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants