Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updating nightly for e2e test (speculos) #6939

Merged
merged 3 commits into from
May 27, 2024

Conversation

valber-ledger
Copy link
Contributor

@valber-ledger valber-ledger commented May 27, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • This PR addresses the issue where variables were set to null during scheduled workflows, causing the nightly runs to execute mocked tests instead of speculos tests.
  • Activation of the Receive test.

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:35am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:35am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:35am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:35am
web-tools ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:35am

@live-github-bot live-github-bot bot added desktop Has changes in LLD automation CI/CD stuff labels May 27, 2024
@valber-ledger valber-ledger marked this pull request as ready for review May 27, 2024 12:08
@valber-ledger valber-ledger requested a review from a team as a code owner May 27, 2024 12:08
@valber-ledger valber-ledger changed the title Support/speculos receive ci: Updating nightly for e2e test (speculos) May 27, 2024
@ypolishchuk-ledger ypolishchuk-ledger merged commit 1f61d65 into develop May 27, 2024
22 of 23 checks passed
@ypolishchuk-ledger ypolishchuk-ledger deleted the Support/speculos-receive branch May 27, 2024 12:44
if [ "${{ inputs.speculos_tests }}" = true ]; then export MOCK=0 && speculos_tests=":speculos"; fi
if [ "${{ inputs.invert_filter }}" = true ]; then invert_filter="-invert"; fi
xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright$speculos_tests ${INPUTS_TEST_FILTER:+--grep$invert_filter} "${{ inputs.test_filter }}"
export ENABLE_TRANSACTION_BROADCAST=${{ inputs.enable_broadcast == 'true' ? true : false || false }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should export 0 or 1 (not true or false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants