-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Updating nightly for e2e test (speculos) #6939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Ignored Deployments
|
valber-ledger
changed the title
Support/speculos receive
ci: Updating nightly for e2e test (speculos)
May 27, 2024
ypolishchuk-ledger
previously approved these changes
May 27, 2024
valber-ledger
force-pushed
the
Support/speculos-receive
branch
from
May 27, 2024 12:33
059bcab
to
2d9d362
Compare
ypolishchuk-ledger
approved these changes
May 27, 2024
if [ "${{ inputs.speculos_tests }}" = true ]; then export MOCK=0 && speculos_tests=":speculos"; fi | ||
if [ "${{ inputs.invert_filter }}" = true ]; then invert_filter="-invert"; fi | ||
xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright$speculos_tests ${INPUTS_TEST_FILTER:+--grep$invert_filter} "${{ inputs.test_filter }}" | ||
export ENABLE_TRANSACTION_BROADCAST=${{ inputs.enable_broadcast == 'true' ? true : false || false }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should export 0 or 1 (not true or false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
null
during scheduled workflows, causing the nightly runs to execute mocked tests instead of speculos tests.π§ Checklist for the PR Reviewers