Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Updating nightly for e2e test (speculos) #6939

Merged
merged 3 commits into from
May 27, 2024
Merged

ci: Updating nightly for e2e test (speculos) #6939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
686423c
ci: e2e nightly - setup default value to variables
valber-ledger May 27, 2024
f9525cd
ci: ENABLE_TRANSACTION_BROADCAST
valber-ledger May 27, 2024
2d9d362
ci: adding changeset
valber-ledger May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strange-monkeys-return.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ledger-live-desktop": minor
---

updating workflow: adding default value to variables
11 changes: 6 additions & 5 deletions .github/workflows/test-ui-e2e-only-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,13 @@ jobs:
id: tests
run: |
export COINAPPS=$PWD/coin-apps
if [ "${{ inputs.enable_broadcast }}" = true ]; then export ENABLE_TRANSACTION_BROADCAST=1; fi
if [ "${{ inputs.speculos_tests }}" = true ]; then export MOCK=0 && speculos_tests=":speculos"; fi
if [ "${{ inputs.invert_filter }}" = true ]; then invert_filter="-invert"; fi
xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright$speculos_tests ${INPUTS_TEST_FILTER:+--grep$invert_filter} "${{ inputs.test_filter }}"
export ENABLE_TRANSACTION_BROADCAST=${{ inputs.enable_broadcast == 'true' ? true : false || false }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should export 0 or 1 (not true or false)

export MOCK=${{ inputs.speculos_tests == 'true' ? 0 : 1 || 0 }}
speculos_tests=${{ inputs.speculos_tests == 'true' ? ":speculos" : "" || ":speculos" }}
invert_filter=${{ inputs.invert_filter == 'true' ? "-invert" : "" || "" }}
xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright$speculos_tests ${inputs.test_filter && "--grep$invert_filter"} "${{ inputs.test_filter || '' }}"
env:
INPUTS_TEST_FILTER: ${{ inputs.test_filter }}
INPUTS_TEST_FILTER: ${{ inputs.test_filter || '' }}
SEED: ${{ secrets.SEED_QAA_B2C }}
- name: upload diffs to s3
if: ${{ !cancelled() }}
Expand Down
Loading