Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/LIVE-12702]: Use targetAccountCurrency name if accountNameSelector returns null or undefined #6960

Merged
merged 4 commits into from
May 29, 2024

Conversation

kallen-ledger
Copy link
Contributor

@kallen-ledger kallen-ledger commented May 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • In the case of a token currency the target account name is not shown.
  • Use targetAccountCurrency name if accountNameSelector returns null or undefined.

Before

Screenshot 2024-05-29 at 11 21 43

After

Screenshot 2024-05-29 at 11 18 33

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-12702


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 10:12am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 10:12am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 10:12am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 10:12am
web-tools ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 10:12am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 29, 2024
@kallen-ledger kallen-ledger marked this pull request as ready for review May 29, 2024 09:31
@kallen-ledger kallen-ledger requested a review from a team as a code owner May 29, 2024 09:31
@kallen-ledger kallen-ledger requested a review from a team May 29, 2024 09:33
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good but lacking a bit of context in the description and in the ticket. Can you add a before/after screenshot or video in the description?

@kallen-ledger
Copy link
Contributor Author

Seems good but lacking a bit of context in the description and in the ticket. Can you add a before/after screenshot or video in the description?

Yes of course, will add that now

Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update with the screenshots πŸ‘ lgtm

@kallen-ledger kallen-ledger merged commit 9a2ce48 into develop May 29, 2024
36 checks passed
@kallen-ledger kallen-ledger deleted the fix/LIVE-12702 branch May 29, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants