Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LIVE-12860): remove popular tag llm #7005

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

lpaquet-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

remove popular tag lln

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-12860


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lpaquet-ledger lpaquet-ledger requested a review from a team as a code owner June 4, 2024 07:43
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 9:49am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 9:49am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 9:49am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 9:49am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 9:49am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jun 4, 2024
@@ -170,7 +170,6 @@ const NoFundsStakeModal = ({ account, parentAccount, entryPoint }: NoFundsStakeM
<EntryButton
Icon={() => <Icon name="BuyCrypto" />}
title={t("stake.noFundsModal.options.swap.title")}
label={t("stake.noFundsModal.options.swap.label")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can maybe remove it from common.json?

@live-github-bot live-github-bot bot added the translations Translation files have been touched label Jun 4, 2024
@lpaquet-ledger lpaquet-ledger merged commit 4a097ca into develop Jun 7, 2024
48 checks passed
@lpaquet-ledger lpaquet-ledger deleted the feat/LIVE-12860 branch June 7, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants