Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LIVE-12860): remove popular tag llm #7005

Merged
merged 3 commits into from
Jun 7, 2024
Merged

feat(LIVE-12860): remove popular tag llm #7005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61cb924
feat(LIVE-12860): remove popular tag llm
lpaquet-ledger Jun 3, 2024
43f60ec
feat(LIVE-12860): remove popular tag everywhere
lpaquet-ledger Jun 4, 2024
33cd809
feat(LIVE-12860): remove from common.json
lpaquet-ledger Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-crabs-arrive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"live-mobile": patch
---

remove popular tag
1 change: 0 additions & 1 deletion apps/ledger-live-desktop/src/renderer/modals/NoFundsStake/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ const NoFundsStakeModal = ({ account, parentAccount, entryPoint }: NoFundsStakeM
<EntryButton
Icon={() => <Icon name="BuyCrypto" />}
title={t("stake.noFundsModal.options.swap.title")}
label={t("stake.noFundsModal.options.swap.label")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can maybe remove it from common.json?

body={t("stake.noFundsModal.options.swap.body")}
onClick={onSwap}
showChevron
Expand Down
1 change: 0 additions & 1 deletion apps/ledger-live-desktop/src/renderer/screens/dashboard/FeaturedButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ const FeaturedButtons = () => {
Icon={() => <IconsLegacy.BuyCryptoMedium size={18} />}
title={t("dashboard.featuredButtons.swap.title")}
body={t("dashboard.featuredButtons.swap.description")}
label={t("dashboard.featuredButtons.swap.label")}
onClick={handleClickSwap}
entryButtonTestId="swap-entry-button"
/>
Expand Down
1 change: 0 additions & 1 deletion apps/ledger-live-mobile/src/components/NoFunds/NoFunds.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ export default function NoFunds({ route }: Props) {
{
title: t("stake.noFundsModal.options.swap.title"),
description: t("stake.noFundsModal.options.swap.body"),
tag: t("stake.noFundsModal.options.swap.label"),
Icon: IconsLegacy.BuyCryptoMedium,
onPress: onSwap,
disabled: !availableOnSwap,
Expand Down
1 change: 0 additions & 1 deletion apps/ledger-live-mobile/src/components/TabBar/TransferDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ export default function TransferDrawer({ onClose }: Omit<ModalProps, "isRequesti
title: t("transfer.swap.title"),
description: t("transfer.swap.description"),
Icon: SWAP.icon,
tag: t("common.popular"),
onPress: () => onNavigate(...SWAP.route),
onDisabledPress: () => {
if (isPtxServiceCtaExchangeDrawerDisabled) {
Expand Down
1 change: 0 additions & 1 deletion apps/ledger-live-mobile/src/locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6578,7 +6578,6 @@
},
"swap": {
"title": "Swap",
"label": "Popular",
"body": "Convert crypto to crypto securely"
},
"receive": {
Expand Down
Loading