Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSDK-331][LLD] Europa crash MyLedger "cannot ready properties of undefined reading 'dark'" #7017

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Jun 5, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • when opening an app in My Ledger with Europa, a screen shows up

πŸ“ Description

Fix for a crash:
When opening an app while being connected to LLD My Ledger with Europa, a screen shows up, and an asset was missing, causing a crash.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ofreyssinet-ledger ofreyssinet-ledger requested a review from a team as a code owner June 5, 2024 10:27
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 5, 2024 11:14am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 11:14am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 11:14am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 11:14am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 11:14am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 5, 2024
@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Jun 5, 2024
@ofreyssinet-ledger ofreyssinet-ledger changed the title [DSDK-331] Europa crash MyLedger "cannot ready properties of undefined reading 'dark'" [DSDK-331][LLD] Europa crash MyLedger "cannot ready properties of undefined reading 'dark'" Jun 5, 2024
Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type guards incoming hard

@ofreyssinet-ledger ofreyssinet-ledger merged commit afdf567 into develop Jun 7, 2024
63 of 66 checks passed
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/DSDK-331-europa-crash-myledger branch June 7, 2024 09:06
Copy link
Contributor

@aussedatlo aussedatlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@@ -1,12 +1,14 @@
import { DeviceModelId } from ".";

export function isDeviceModelId(val: string | undefined | null): val is DeviceModelId {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants