-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSDK-331][LLD] Europa crash MyLedger "cannot ready properties of undefined reading 'dark'" #7017
Merged
ofreyssinet-ledger
merged 5 commits into
develop
from
bugfix/DSDK-331-europa-crash-myledger
Jun 7, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
02e7f65
fix(lld/myledger): undefined asset for Europa
ofreyssinet-ledger 376cff7
chore: changeset
ofreyssinet-ledger 3b9c93c
feat(ljs:devices): add type narrowing helper isDeviceModelId
ofreyssinet-ledger 80c5f98
fix(lld/MyLedger): device model id typing in Disconnected
ofreyssinet-ledger dfd144f
style(ljs:devices): lint
ofreyssinet-ledger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"ledger-live-desktop": patch | ||
--- | ||
|
||
Fix a crash with Europa in My Ledger when opening an app |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@ledgerhq/devices": patch | ||
--- | ||
|
||
Add type narrowing helper isDeviceModelId |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+19.8 KB
apps/ledger-live-desktop/src/renderer/screens/manager/assets/europa.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
import { DeviceModelId } from "."; | ||
|
||
export function isDeviceModelId(val: string | undefined | null): val is DeviceModelId { | ||
if (!val) return false; | ||
return Object.values(DeviceModelId).includes(val as DeviceModelId); | ||
} | ||
|
||
export const stringToDeviceModelId = ( | ||
strDeviceModelId: string, | ||
defaultDeviceModelId: DeviceModelId, | ||
): DeviceModelId => { | ||
if (Object.values(DeviceModelId)?.includes(strDeviceModelId as DeviceModelId)) { | ||
return DeviceModelId[strDeviceModelId as DeviceModelId]; | ||
} | ||
|
||
return defaultDeviceModelId; | ||
if (!isDeviceModelId(strDeviceModelId)) return defaultDeviceModelId; | ||
return DeviceModelId[strDeviceModelId]; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !