Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Fix overriding the analytics opt in when the analyticsOptInPrompt is only enabled for the Onboarding #7032

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Jun 7, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix overriding the analytics opt in when the analyticsOptInPrompt is only enabled for the Onboarding
Automated tests covering this are coming in another PR very soon

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner June 7, 2024 10:01
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:31pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:31pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:31pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:31pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:31pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Jun 7, 2024
…tics opt in prompt feature flags are enabled
@cgrellard-ledger cgrellard-ledger merged commit 68fab96 into develop Jun 10, 2024
49 of 51 checks passed
@cgrellard-ledger cgrellard-ledger deleted the bugfix/live-12646 branch June 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants