Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Hotfix 2024-07-02 #7241

Merged
merged 13 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 117 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
{
"mode": "pre",
"tag": "hotfix",
"initialVersions": {
"@ledgerhq/live-cli": "24.3.1",
"ledger-live-desktop": "2.82.1",
"live-mobile": "3.45.1",
"@ledgerhq/web-tools": "0.6.1",
"@ledgerhq/docs-libs": "0.1.0",
"@ledgerhq/coin-framework": "0.14.0",
"@ledgerhq/coin-algorand": "0.5.0",
"@ledgerhq/coin-bitcoin": "0.6.0",
"@ledgerhq/coin-cardano": "0.1.0",
"@ledgerhq/coin-evm": "2.1.0",
"@ledgerhq/coin-near": "0.5.0",
"@ledgerhq/coin-polkadot": "0.8.0",
"@ledgerhq/coin-solana": "0.7.0",
"@ledgerhq/coin-tezos": "0.4.0",
"@ledgerhq/coin-xrp": "0.2.0",
"@ledgerhq/coin-tester": "0.2.0",
"@ledgerhq/device-core": "0.2.0",
"@ledgerhq/device-react": "0.2.0",
"@ledgerhq/domain-service": "1.2.0",
"@ledgerhq/live-env": "2.1.0",
"@ledgerhq/ethereum-provider": "0.3.0",
"@ledgerhq/evm-tools": "1.1.0",
"@ledgerhq/wallet-api-exchange-module": "0.7.0",
"@ledgerhq/hw-trustchain": "0.1.1",
"@ledgerhq/live-common": "34.4.0",
"@ledgerhq/ledger-libs": "0.1.3",
"@ledgerhq/context-module": "0.0.2",
"@ledgerhq/cryptoassets": "13.1.0",
"@ledgerhq/devices": "8.4.0",
"@ledgerhq/errors": "6.17.0",
"@ledgerhq/hw-app-algorand": "6.29.0",
"@ledgerhq/hw-app-btc": "10.3.0",
"@ledgerhq/hw-app-cosmos": "6.30.0",
"@ledgerhq/hw-app-eth": "6.37.0",
"@ledgerhq/hw-app-exchange": "0.5.0",
"@ledgerhq/hw-app-helium": "6.31.0",
"@ledgerhq/hw-app-near": "6.29.0",
"@ledgerhq/hw-app-polkadot": "6.30.0",
"@ledgerhq/hw-app-solana": "7.2.0",
"@ledgerhq/hw-app-str": "6.29.0",
"@ledgerhq/hw-app-tezos": "6.29.0",
"@ledgerhq/hw-app-trx": "6.29.0",
"@ledgerhq/hw-app-vet": "0.2.0",
"@ledgerhq/hw-app-xrp": "6.29.0",
"@ledgerhq/hw-transport": "6.31.0",
"@ledgerhq/hw-transport-http": "6.30.0",
"@ledgerhq/hw-transport-mocker": "6.29.0",
"@ledgerhq/hw-transport-node-hid": "6.29.0",
"@ledgerhq/hw-transport-node-hid-noevents": "6.30.0",
"@ledgerhq/hw-transport-node-hid-singleton": "6.31.0",
"@ledgerhq/hw-transport-node-speculos": "6.29.0",
"@ledgerhq/hw-transport-node-speculos-http": "6.29.0",
"@ledgerhq/hw-transport-vault": "1.3.0",
"@ledgerhq/hw-transport-web-ble": "6.29.0",
"@ledgerhq/hw-transport-webhid": "6.29.0",
"@ledgerhq/hw-transport-webusb": "6.29.0",
"@ledgerhq/keyring-eth": "0.1.0",
"@ledgerhq/logs": "6.12.0",
"@ledgerhq/react-native-hid": "6.32.0",
"@ledgerhq/react-native-hw-transport-ble": "6.33.0",
"@ledgerhq/swift-bridge-hw-app-eth": "1.2.0",
"@ledgerhq/swift-bridge-hw-app-solana": "1.2.0",
"@ledgerhq/swift-bridge-hw-transport-ble": "1.2.0",
"@ledgerhq/types-cryptoassets": "7.13.0",
"@ledgerhq/types-devices": "6.25.0",
"@ledgerhq/types-live": "6.48.0",
"@ledgerhq/live-config": "3.0.0",
"@ledgerhq/live-countervalues": "0.2.0",
"@ledgerhq/live-countervalues-react": "0.2.0",
"@ledgerhq/live-hooks": "0.1.0",
"@ledgerhq/live-network": "1.3.0",
"@ledgerhq/live-nft": "0.4.0",
"@ledgerhq/live-nft-react": "0.4.0",
"@ledgerhq/live-wallet": "0.2.0",
"@ledgerhq/live-promise": "0.1.0",
"@ledgerhq/speculos-transport": "0.1.1",
"@ledgerhq/test-utils": "0.2.1",
"@ledgerhq/trustchain": "0.1.1",
"@ledgerhq/ui": "0.2.1",
"@ledgerhq/next.js-example": "0.1.0",
"@ledgerhq/webpack.js-example": "0.1.0",
"@ledgerhq/crypto-icons-ui": "1.2.0",
"@ledgerhq/icons-ui": "0.7.0",
"@ledgerhq/native-ui": "0.23.0",
"@ledgerhq/react-ui": "0.15.0",
"@ledgerhq/ui-shared": "0.2.1",
"@ledgerhq/dummy-live-app": "0.2.0",
"@ledgerhq/dummy-ptx-app": "0.0.1",
"@ledgerhq/dummy-wallet-app": "0.3.1",
"@ledgerhq/actions-root": "0.1.0",
"@actions/build-checks": "1.2.0",
"@actions/change-product-name": "1.0.1",
"@actions/desktop-report-build": "1.0.1",
"@actions/generate-bot-super-report": "1.0.2",
"@actions/generate-release-message": "1.1.0",
"@actions/get-package-infos": "1.1.0",
"@actions/get-workflow-artifacts-id": "1.1.0",
"@actions/live-common-affected": "1.0.0",
"@actions/prepare-comment-screenshots": "1.0.1",
"@actions/submit-bot-report": "1.1.0",
"@actions/turbo-affected": "1.1.0",
"@actions/turborepo-gh-cache": "1.0.1",
"@actions/turborepo-s3-cache": "1.0.1",
"@actions/upload-images": "2.1.0",
"@ledgerhq/create-release-hash": "1.0.0",
"@ledgerhq/esbuild-utils": "1.0.1",
"@ledgerhq/live-github-bot": "1.1.0",
"@ledgerhq/native-modules-tools": "1.0.3",
"@ledgerhq/pnpm-utils": "1.0.1",
"@ledgerhq/react-devtools": "0.0.0"
},
"changesets": []
}
5 changes: 5 additions & 0 deletions .changeset/witty-clouds-change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"live-mobile": patch
---

Add version check for nano X bluetooth firmware update
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import React, { memo } from "react";
import React, { memo, useMemo } from "react";
import { Pressable } from "react-native";
import { useTranslation } from "react-i18next";
import { Text, Flex, Icons } from "@ledgerhq/native-ui";
import { DownloadMedium, UsbMedium } from "@ledgerhq/native-ui/assets/icons";
import { DeviceModelId, getDeviceModel } from "@ledgerhq/devices";
import semver from "semver";

import Button from "~/components/Button";
import QueuedDrawer from "~/components/QueuedDrawer";
Expand All @@ -29,8 +30,24 @@ const UpdateBanner = ({
? getDeviceModel(lastConnectedDevice.modelId).productName
: undefined;

const connectionType = lastConnectedDevice?.wired ? "usb" : "bluetooth";
const deviceName = lastConnectedDevice?.deviceName;
return bannerVisible ? (

const shouldDisplay = useMemo(() => {
if (!bannerVisible || !version) {
return false;
}

if (connectionType === "bluetooth") {
if (lastConnectedDevice?.modelId === DeviceModelId.nanoX) {
return semver.gt(version, "2.4.0");
}
}

return true;
}, [bannerVisible, connectionType, lastConnectedDevice, version]);

return shouldDisplay ? (
<>
<Pressable onPress={onClickUpdate} testID="fw-update-banner">
<Flex
Expand Down
Loading