🔥 Hotfix 2024-07-02 #7241
Merged
🔥 Hotfix 2024-07-02 #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
smartine-ledger
previously approved these changes
Jul 2, 2024
mbertin-ledger
previously approved these changes
Jul 2, 2024
live-github-bot
bot
dismissed stale reviews from mbertin-ledger and smartine-ledger
via
afd2352
…-hotfix bugfix: LIVE-13226 polkadot send for runtime upgrade
live-github-bot
bot
added
common
…fw update banner with the new rules for nano x
KVNLS
previously approved these changes
Jul 3, 2024
...ive-mobile/src/newArch/features/FirmwareUpdate/components/UpdateBanner/UpdateBanner.test.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+102
to
106
| (connectionType === "bluetooth" && | ||
| Platform.OS === "android" && | ||
| !!lastSeenDeviceModelInfo && | ||
| semver.lt(lastSeenDeviceModelInfo?.deviceInfo.version, "2.4.0")), | ||
| }; |
There was a problem hiding this comment.
this is missing a condition on the device model no?
There was a problem hiding this comment.
I would say isOldUxSupportedButNotWired already takes care of that but you might be right.....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next release is on the way 🚀!
This pull request aims to fix a bug in production for a Ledger Live product.
Checklist
To be ready to be merged, we must comply with all theses checks:
Once all these checks are validated, the pull request can be merged using the correct workflow.