-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] first draft of PDBx Reader #4303
base: develop
Are you sure you want to change the base?
Conversation
Linter Bot Results:Hi @richardjgowers! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #4303 +/- ##
===========================================
- Coverage 93.40% 93.15% -0.26%
===========================================
Files 170 186 +16
Lines 22257 23429 +1172
Branches 4071 4079 +8
===========================================
+ Hits 20790 21825 +1035
- Misses 951 1088 +137
Partials 516 516
☔ View full report in Codecov by Sentry. |
Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Do you want reviews on this, @richardjgowers ? |
Fixes #
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4303.org.readthedocs.build/en/4303/