Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rdkit tests #4640

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Fix rdkit tests #4640

merged 4 commits into from
Jul 24, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 22, 2024

Fixes #4624

Changes made in this Pull Request:

  • Update coordinate checks
  • Remove numpy >=2 skips (latest release supports numpy 2.0)

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4640.org.readthedocs.build/en/4640/

@pep8speaks
Copy link

pep8speaks commented Jul 22, 2024

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-23 22:28:45 UTC

@IAlibay IAlibay mentioned this pull request Jul 22, 2024
5 tasks
Copy link

github-actions bot commented Jul 22, 2024

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ✅ Passed
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/10067283837/job/27830432992


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (1bf58cc) to head (1378d5c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4640      +/-   ##
===========================================
- Coverage    93.61%   93.59%   -0.03%     
===========================================
  Files          171      183      +12     
  Lines        21250    22316    +1066     
  Branches      3936     3936              
===========================================
+ Hits         19893    20886     +993     
- Misses         898      971      +73     
  Partials       459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Jul 22, 2024

The test is inherently flawed because we know that even at a fixed seed the conformer generation will differ on different machines (it's caused trouble elsewhere). We should just test against on the fly generated coordinates.

@IAlibay IAlibay requested a review from RMeli July 22, 2024 22:50
@RMeli RMeli enabled auto-merge (squash) July 23, 2024 06:30
@RMeli RMeli merged commit b227f17 into develop Jul 24, 2024
20 of 23 checks passed
@RMeli RMeli deleted the rdkit-fix branch July 24, 2024 06:34
@RMeli
Copy link
Member

RMeli commented Jul 24, 2024

Mmmh... Not sure why I enabled auto-merge here (I didn't realize)... The few failures in CI are the usual timeouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin rdkit imports once rdkit supports numpy 2.0
3 participants