-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pointlessly install PhantomJS on Travis #11929
Conversation
|
dbe2142
to
412f97b
Compare
The gemified version of Jasmine uses the gemified version of PhantomJS which auto-installs it if it can't find your installation in ~/.phantomjs Travis already has a version of PhantomJS installed in a different location, so the gem will auto-install even if it's pointless. Also, gemified PhantomJS hardcodes install URLs from BitBucket which times out and causes failed builds. TLDR: Don't install auto-install PhantomJS on CI. In Travis we trust.
412f97b
to
445bad9
Compare
Ran this change in Travis 3-4 times, hasn't failed yet (and is faster, as we're not installing PhantomJS needlessly...) Calling it good. |
So much yes with this! I can't believe that the jasmine gem did this, nice catch! I guess what I didn't realize (which was a great link to include in this PR, thanks Chris) is that we would be using an older version of Phantom.js (1.9.8 I believe), so that might be of concern. Not my area of expertise, but something for the reviewers to definitely make note of. |
👍 LGTM |
Yup, CI will run an older version of Phantom than what's installed on the gem. As long as the tests pass I see no problems for now. There are other ways you can manually install v2 on Travis but we might as well wait and see, if ever, Travis just eventually makes v2 available. |
Don't pointlessly install PhantomJS on Travis (cherry picked from commit 284fd0a)
Euwe Backport details: $ git log -1
commit 6ed2876fbed142011c730a6fcc71abf3d789bd5e
Author: Brandon Dunne <[email protected]>
Date: Fri Oct 14 17:53:28 2016 -0400
Merge pull request #11929 from chrisarcand/alternate-phantomjs-cdn
Don't pointlessly install PhantomJS on Travis
(cherry picked from commit 284fd0a5e6d268de4b3619acd050ddc02abb953b) |
~/.phantomjs
. Travis already has a version of PhantomJS installed in a different location, so the gem will auto-install even if it's pointless.and causes failed builds:
TLDR: Don't install auto-install PhantomJS on CI. In Travis we trust.
Links