Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pointlessly install PhantomJS on Travis #11929

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Don't pointlessly install PhantomJS on Travis #11929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions spec/javascripts/support/jasmine_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
# You can remove it if you don't need it.
# This file is loaded *after* jasmine.yml is interpreted.
#
# Example: using a different boot file.
# Jasmine.configure do |config|
# config.boot_dir = '/absolute/path/to/boot_dir'
# config.boot_files = lambda { ['/absolute/path/to/boot_dir/file.js'] }
# end
#
# Example: prevent PhantomJS auto install, uses PhantomJS already on your path.
# Jasmine.configure do |config|
# config.prevent_phantom_js_auto_install = true
# end
Jasmine.configure do |config|
# The gemified version of Jasmine uses the gemified version of PhantomJS
# which auto-installs it if it can't find your installation in ~/.phantomjs
# Travis already has a version of PhantomJS installed in a different
# location, so the gem will auto-install even if it's pointless. Also,
# gemified PhantomJS hardcodes install URLs from BitBucket which times out
# and causes failed builds.
#
# TLDR: Don't install auto-install PhantomJS on CI. In Travis we trust.
config.prevent_phantom_js_auto_install = true if ENV['CI']
end